From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D56CFC433F4 for ; Mon, 27 Aug 2018 20:57:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8926C208B7 for ; Mon, 27 Aug 2018 20:57:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8926C208B7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727501AbeH1ApV (ORCPT ); Mon, 27 Aug 2018 20:45:21 -0400 Received: from mail.bootlin.com ([62.4.15.54]:52380 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726958AbeH1ApV (ORCPT ); Mon, 27 Aug 2018 20:45:21 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id F127B207B0; Mon, 27 Aug 2018 22:57:03 +0200 (CEST) Received: from localhost (unknown [88.191.26.124]) by mail.bootlin.com (Postfix) with ESMTPSA id C786320734; Mon, 27 Aug 2018 22:57:03 +0200 (CEST) Date: Mon, 27 Aug 2018 22:57:03 +0200 From: Alexandre Belloni To: Quentin Schulz Cc: Rob Herring , ralf@linux-mips.org, paul.burton@mips.com, jhogan@kernel.org, mark.rutland@arm.com, davem@davemloft.net, kishon@ti.com, andrew@lunn.ch, f.fainelli@gmail.com, linux-mips@linux-mips.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, allan.nielsen@microsemi.com, thomas.petazzoni@bootlin.com Subject: Re: [PATCH net-next 02/10] dt-bindings: net: ocelot: remove hsio from the list of register address spaces Message-ID: <20180827205703.GE24549@piout.net> References: <3558e538b55a2249b0a179c04c27e9d3715bbbaa.1532954208.git-series.quentin.schulz@bootlin.com> <20180813223103.GA16669@rob-hp-laptop> <20180814064953.vboz2gryq4jff34n@qschulz> <20180814124135.GK943@piout.net> <20180816142514.pf4eiqeditoy4uei@qschulz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180816142514.pf4eiqeditoy4uei@qschulz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/08/2018 16:25:14+0200, Quentin Schulz wrote: > Hi Alexandre, > > On Tue, Aug 14, 2018 at 02:41:35PM +0200, Alexandre Belloni wrote: > > On 14/08/2018 08:49:53+0200, Quentin Schulz wrote: > > > Understood but it's an intermediate patch. Later (patch 8), the SerDes > > > muxing "controller" is added as a child to this node. There most likely > > > will be some others in the future (temperature sensor for example). > > > > > > Furthermore, there's already a simple-mfd without children in this file: > > > https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/mips/mscc.txt#L19 > > > > > > How should we handle this case? > > > > > > > There were child nodes in previous version of the binding. You can > > remove simple-mfd now. The useful registers that are not used by any > > drivers are gpr and chipid. > > > > And what about the use case I'm facing? I've got child nodes defined in > it but with a later patch (but they actually haven't made it to the > DT binding documentation, so that's for the next version of the patch > series). > I guess you should keep simple-mfd for hsio because it will have child nodes. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com