From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79210C433F5 for ; Thu, 30 Aug 2018 02:46:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2196820647 for ; Thu, 30 Aug 2018 02:46:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2196820647 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727329AbeH3GqW (ORCPT ); Thu, 30 Aug 2018 02:46:22 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:40006 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725788AbeH3GqW (ORCPT ); Thu, 30 Aug 2018 02:46:22 -0400 Received: from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net [74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C0750108F8657; Wed, 29 Aug 2018 19:46:28 -0700 (PDT) Date: Wed, 29 Aug 2018 19:46:28 -0700 (PDT) Message-Id: <20180829.194628.1640012269371401850.davem@davemloft.net> To: mkubecek@suse.cz Cc: netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 0/2] ethtool: drop get_settings and set_settings ops From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 29 Aug 2018 19:46:29 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michal Kubecek Date: Tue, 28 Aug 2018 19:56:48 +0200 (CEST) > As Andrew Lunn pointed out in recent discussion, there is only one in tree > driver left which still defines deprecated callbacks get_settings() and > set_settings() in ethtool_ops. First patch converts this driver to > get_link_ksettings() and set_link_ksettings(). Second patch then removes > the deprecated callbacks from struct ethtool_ops and ethtool code which > falls back to them. > > This doesn't break old versions of ethtool or any other userspace code > using ETHTOOL_{G,S}SET. We still implement both (old) ETHTOOL_{G,S}SET and > (new) ETHTOOL_{G,S}LINKSETTINGS ioctl commands but after this series both > will be implemented only using {g,s}et_link_ksettings(). The only affected > code would be out of tree NIC drivers which have not been converted yet. Nice, thanks for following up on this. Series applied.