From: Christoph Hellwig <hch@infradead.org>
To: Sam Protsenko <semen.protsenko@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
codalist@coda.cs.cmu.edu, coda@cs.cmu.edu,
Jan Harkes <jaharkes@cs.cmu.edu>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Praneeth Bajjuri <praneeth@ti.com>,
Paul Sokolovsky <paul.sokolovsky@linaro.org>,
Miklos Szeredi <mszeredi@suse.cz>,
Sumit Semwal <sumit.semwal@linaro.org>,
Ruslan Bilovol <ruslan.bilovol@gmail.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH 2/2] scsi: aic7xxx: Fix build using bare-metal toolchain
Date: Tue, 28 Aug 2018 23:32:44 -0700 [thread overview]
Message-ID: <20180829063244.GA32392@infradead.org> (raw)
In-Reply-To: <20180828142421.15335-3-semen.protsenko@linaro.org>
On Tue, Aug 28, 2018 at 05:24:21PM +0300, Sam Protsenko wrote:
> Bare-metal toolchains don't define __linux__, so aic7xxx build with
> bare-metal toolchain is broken. Let's check __KERNEL__ definition
> instead of __linux__ (as this code won't be build for user-space anyway)
> in order to fix that.
Please just drop the ifdefs entirely. The codebase used to be partially
shared with at least FreeBSD, but these days there is no point in
keeping the compatibility around.
next prev parent reply other threads:[~2018-08-29 6:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 14:24 [PATCH 0/2] Fix allmodconfig build with bare-metal toolchain Sam Protsenko
2018-08-28 14:24 ` [PATCH 1/2] codafs: Fix build using " Sam Protsenko
2018-08-28 17:03 ` Andy Shevchenko
2018-08-28 17:07 ` Andy Shevchenko
2018-08-29 6:33 ` Christoph Hellwig
2018-08-29 14:03 ` Sam Protsenko
2018-08-28 14:24 ` [PATCH 2/2] scsi: aic7xxx: " Sam Protsenko
2018-08-29 6:32 ` Christoph Hellwig [this message]
2018-08-29 14:01 ` Sam Protsenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180829063244.GA32392@infradead.org \
--to=hch@infradead.org \
--cc=andy.shevchenko@gmail.com \
--cc=coda@cs.cmu.edu \
--cc=codalist@coda.cs.cmu.edu \
--cc=jaharkes@cs.cmu.edu \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mszeredi@suse.cz \
--cc=paul.sokolovsky@linaro.org \
--cc=praneeth@ti.com \
--cc=ruslan.bilovol@gmail.com \
--cc=semen.protsenko@linaro.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox