From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH v1 04/10] perf, tools, script: Allow sym and dso without ip, addr
Date: Thu, 30 Aug 2018 10:56:48 +0200 [thread overview]
Message-ID: <20180830085648.GC16691@krava> (raw)
In-Reply-To: <20180829171834.6590-5-andi@firstfloor.org>
On Wed, Aug 29, 2018 at 10:18:28AM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> Currently sym and dso require printing ip and addr because
> the print function is tied to those outputs. With callindent
> it makes sense to print the symbol or dso without numerical
> IP or ADDR. So change the dependency check to only check the
> underlying attribute.
>
> This allows to remove a lot of noise in callindent output by
> dropping the numerical addresses, which are not all that useful.
>
> Before
>
> % perf script --itrace=cr -F +callindent
> swapper 0 [000] 156546.354971: 1 branches: pt_config 0 [unknown] ([unknown]) => ffffffff81010486 pt_config ([kernel.kallsyms])
> swapper 0 [000] 156546.354971: 1 branches: pt_config ffffffff81010499 pt_config ([kernel.kallsyms]) => ffffffff8101063e pt_event_add ([kernel.kallsyms])
> swapper 0 [000] 156546.354971: 1 branches: pt_event_add ffffffff81010635 pt_event_add ([kernel.kallsyms]) => ffffffff8115e687 event_sched_in.isra.107 ([kernel.kallsyms])
> swapper 0 [000] 156546.354971: 1 branches: perf_pmu_enable ffffffff8115e726 event_sched_in.isra.107 ([kernel.kallsyms]) => ffffffff811579b0 perf_pmu_enable ([kernel.kallsyms])
> swapper 0 [000] 156546.354971: 1 branches: perf_pmu_nop_void ffffffff81151730 perf_pmu_nop_void ([kernel.kallsyms]) => ffffffff8115e72b event_sched_in.isra.107 ([kernel.kallsyms])
> swapper 0 [000] 156546.354971: 1 branches: event_sched_in.isra.107 ffffffff8115e737 event_sched_in.isra.107 ([kernel.kallsyms]) => ffffffff8115e7a5 group_sched_in ([kernel.kallsyms])
> swapper 0 [000] 156546.354971: 1 branches: __x86_indirect_thunk_rax ffffffff8115e7f6 group_sched_in ([kernel.kallsyms]) => ffffffff81a03000 __x86_indirect_thunk_rax ([kernel.kallsyms])
>
> After
>
> % perf script --itrace=cr -F +callindent,-ip,-sym
> swapper 0 [000] 156546.354971: 1 branches: pt_config
> swapper 0 [000] 156546.354971: 1 branches: pt_config
> swapper 0 [000] 156546.354971: 1 branches: pt_event_add
> swapper 0 [000] 156546.354971: 1 branches: perf_pmu_enable
> swapper 0 [000] 156546.354971: 1 branches: perf_pmu_nop_void
> swapper 0 [000] 156546.354971: 1 branches: event_sched_in.isra.107
> swapper 0 [000] 156546.354971: 1 branches: __x86_indirect_thunk_rax
> swapper 0 [000] 156546.354971: 1 branches: perf_pmu_nop_int
> swapper 0 [000] 156546.354971: 1 branches: group_sched_in
> swapper 0 [000] 156546.354971: 1 branches: event_filter_match
> swapper 0 [000] 156546.354971: 1 branches: event_filter_match
> swapper 0 [000] 156546.354971: 1 branches: group_sched_in
[jolsa@krava perf]$ ./perf script --itrace=cr -F +callindent,-ip,-sym
Display of offsets requested but symbol is notselected.
jirka
next prev parent reply other threads:[~2018-08-30 8:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 17:18 Make perf script easier to use for itrace Andi Kleen
2018-08-29 17:18 ` [PATCH v1 01/10] perf tools: Report itrace options in help Andi Kleen
2018-08-30 8:56 ` Jiri Olsa
2018-08-29 17:18 ` [PATCH v1 02/10] tools, pager: Support overwriting the pager Andi Kleen
2018-08-29 17:18 ` [PATCH v1 03/10] tools, perf, script: Add --insn-trace for instruction decoding Andi Kleen
2018-08-30 8:56 ` Jiri Olsa
2018-08-30 13:55 ` Andi Kleen
2018-09-19 18:12 ` Arnaldo Carvalho de Melo
2018-09-19 20:02 ` Andi Kleen
2018-09-19 20:38 ` Arnaldo Carvalho de Melo
2018-08-29 17:18 ` [PATCH v1 04/10] perf, tools, script: Allow sym and dso without ip, addr Andi Kleen
2018-08-30 8:56 ` Jiri Olsa [this message]
2018-08-29 17:18 ` [PATCH v1 05/10] perf, tools, script: Print DSO for callindent Andi Kleen
2018-08-30 8:57 ` Jiri Olsa
2018-08-29 17:18 ` [PATCH v1 06/10] tools, perf, script: Set user_set/wildcard_set for +- fields in -F Andi Kleen
2018-08-30 8:59 ` Jiri Olsa
2018-08-29 17:18 ` [PATCH v1 07/10] perf, tools, script: Implement - for typed fields Andi Kleen
2018-08-29 17:18 ` [PATCH v1 08/10] perf, tools, script: Make itrace script default to all calls Andi Kleen
2018-08-29 17:18 ` [PATCH v1 09/10] tools, perf, script: Add --call-trace and --call-ret-trace Andi Kleen
2018-08-29 17:18 ` [PATCH v1 10/10] tools, perf, script: Implement --graph-function Andi Kleen
2018-08-30 8:42 ` Make perf script easier to use for itrace Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180830085648.GC16691@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox