From: Feng Tang <feng.tang@intel.com>
To: linux-kernel@vger.kernel.org, x86@kernel.org,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H . Peter Anvin" <hpa@linux.intel.com>,
Yinghai Lu <yinghai@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Dave Hansen <dave.hansen@intel.com>,
Andi Kleen <ak@linux.intel.com>
Cc: Feng Tang <feng.tang@intel.com>
Subject: [PATCH] x86, mm: Reserver some memory for bootmem allocator for NO_BOOTMEM
Date: Thu, 30 Aug 2018 17:03:19 +0800 [thread overview]
Message-ID: <20180830090319.985-1-feng.tang@intel.com> (raw)
We hit a kernel panic when enabling earlycon for a platform, the
call trace is:
panic+0xd2/0x220
__alloc_bootmem+0x31/0x34
spp_getpage+0x60/0x8a
fill_pte+0x71/0x130
__set_pte_vaddr+0x1d/0x50
set_pte_vaddr+0x3c/0x60
__native_set_fixmap+0x23/0x30
native_set_fixmap+0x30/0x40
setup_earlycon+0x1e0/0x32f
param_setup_earlycon+0x13/0x22
do_early_param+0x5b/0x90
parse_args+0x1f7/0x300
parse_early_options+0x24/0x28
parse_early_param+0x65/0x73
setup_arch+0x31e/0x9f1
start_kernel+0x58/0x44e
The root cause is that when CONFIG_NO_BOOTMEM=y, before
e820__memblock_setup() is called there is no memory for bootmem
to allocate, and any alloc_bootmem() in this time window will
trigger a panic. Seems this is a known issue as already
mentioned in arch/x86/kernel/setup.c:
"
/* after early param, so could get panic from serial */
memblock_x86_reserve_range_setup_data();
"
By reserving some memory in the linker script, small memory request
could be fulfilled by bootmem allocator. And this memory region
is not wasted, but usable after kernel boot.
Signed-off-by: Feng Tang <feng.tang@intel.com>
---
arch/x86/include/asm/sections.h | 5 +++++
arch/x86/kernel/setup.c | 12 +++++++++++-
arch/x86/kernel/vmlinux.lds.S | 9 +++++++++
3 files changed, 25 insertions(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/sections.h b/arch/x86/include/asm/sections.h
index 4a911a382ade..d568829510e4 100644
--- a/arch/x86/include/asm/sections.h
+++ b/arch/x86/include/asm/sections.h
@@ -9,6 +9,11 @@ extern char __brk_base[], __brk_limit[];
extern struct exception_table_entry __stop___ex_table[];
extern char __end_rodata_aligned[];
+#ifdef CONFIG_NO_BOOTMEM
+extern char __bootmem_start[], __bootmem_end[];
+#endif
+
+
#if defined(CONFIG_X86_64)
extern char __end_rodata_hpage_align[];
extern char __entry_trampoline_start[], __entry_trampoline_end[];
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index b4866badb235..a4e3d9ec1a83 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -829,6 +829,17 @@ void __init setup_arch(char **cmdline_p)
*/
memblock_reserve(0, PAGE_SIZE);
+#ifdef CONFIG_NO_BOOTMEM
+ /*
+ * There is small time window till e820__memblock_setup() is
+ * called, in which __bootmem_alloc() has no available memory
+ * to allocate and will trigger panic. Adding this revered bootmem
+ * can alleviate the situation.
+ */
+ memblock_add(__pa_symbol(__bootmem_start),
+ __bootmem_end - __bootmem_start);
+#endif
+
early_reserve_initrd();
/*
@@ -989,7 +1000,6 @@ void __init setup_arch(char **cmdline_p)
x86_report_nx();
- /* after early param, so could get panic from serial */
memblock_x86_reserve_range_setup_data();
if (acpi_mps_check()) {
diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
index 8bde0a419f86..fec1965d668f 100644
--- a/arch/x86/kernel/vmlinux.lds.S
+++ b/arch/x86/kernel/vmlinux.lds.S
@@ -367,6 +367,15 @@ SECTIONS
__brk_limit = .;
}
+#ifdef CONFIG_NO_BOOTMEM
+ . = ALIGN(PAGE_SIZE);
+ .bootmem : AT(ADDR(.bootmem) - LOAD_OFFSET) {
+ __bootmem_start = .;
+ . += 128 * 1024; /* 128 KB for early boot mem */
+ __bootmem_end = .;
+ }
+#endif
+
. = ALIGN(PAGE_SIZE); /* keep VO_INIT_SIZE page aligned */
_end = .;
--
2.14.1
next reply other threads:[~2018-08-30 8:58 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 9:03 Feng Tang [this message]
2018-08-30 10:44 ` [PATCH] x86, mm: Reserver some memory for bootmem allocator for NO_BOOTMEM Peter Zijlstra
2018-08-30 11:12 ` Michal Hocko
2018-08-30 11:54 ` Thomas Gleixner
2018-08-30 12:49 ` Michal Hocko
2018-08-30 12:59 ` Feng Tang
2018-08-30 13:05 ` Thomas Gleixner
2018-08-30 13:19 ` Feng Tang
2018-08-30 13:25 ` Thomas Gleixner
2018-08-30 13:55 ` Feng Tang
2018-08-31 6:15 ` Feng Tang
2018-08-31 11:33 ` Thomas Gleixner
2018-08-31 13:36 ` Feng Tang
2018-09-07 8:17 ` Feng Tang
2018-09-07 10:52 ` Thomas Gleixner
2018-09-10 9:39 ` Feng Tang
2018-09-10 9:53 ` Thomas Gleixner
2018-09-11 6:14 ` Feng Tang
2018-09-15 10:29 ` Thomas Gleixner
2018-09-15 16:47 ` Feng Tang
2018-09-15 17:28 ` Thomas Gleixner
2018-09-16 14:35 ` Feng Tang
2018-09-16 14:43 ` Thomas Gleixner
2018-09-16 15:06 ` Feng Tang
2018-09-17 7:01 ` Feng Tang
2018-09-17 7:01 ` Thomas Gleixner
2018-08-30 12:09 ` Peter Zijlstra
2018-08-30 12:39 ` Michal Hocko
2018-08-30 12:43 ` Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180830090319.985-1-feng.tang@intel.com \
--to=feng.tang@intel.com \
--cc=ak@linux.intel.com \
--cc=dave.hansen@intel.com \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox