From: Jason Gunthorpe <jgg@ziepe.ca>
To: Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: dledford@redhat.com, leon@kernel.org, ira.weiny@intel.com,
pravin.shedge4linux@gmail.com, hal@mellanox.com,
parav@mellanox.com, haakon.bugge@oracle.com,
bart.vanassche@sandisk.com, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] infiniband: core: mad: Fix a sleep-in-atomic-context bug in ib_mad_recv_done()
Date: Sun, 2 Sep 2018 14:32:29 -0600 [thread overview]
Message-ID: <20180902203229.GA13946@ziepe.ca> (raw)
In-Reply-To: <20180901120659.32509-1-baijiaju1990@gmail.com>
On Sat, Sep 01, 2018 at 08:06:59PM +0800, Jia-Ju Bai wrote:
> The driver may sleep with holding a spinlock.
>
> The function call paths (from bottom to top) in Linux-4.16 are:
>
> [FUNC] alloc_mad_private(GFP_KERNEL)
> drivers/infiniband/core/mad.c, 2264:
> alloc_mad_private in ib_mad_recv_done
> drivers/infiniband/core/cq.c, 45:
> [FUNC_PTR]ib_mad_recv_done in __ib_process_cq
> drivers/infiniband/core/cq.c, 77:
> __ib_process_cq in ib_process_cq_direct
> drivers/infiniband/ulp/srp/ib_srp.c, 2010:
> ib_process_cq_direct in __srp_get_tx_iu
> drivers/infiniband/ulp/srp/ib_srp.c, 2353:
> __srp_get_tx_iu in srp_queuecommand
> drivers/infiniband/ulp/srp/ib_srp.c, 2352:
> _raw_spin_lock_irqsave in srp_queuecommand
>
> [FUNC] alloc_mad_private(GFP_KERNEL)
> drivers/infiniband/core/mad.c, 2264:
> alloc_mad_private in ib_mad_recv_done
> drivers/infiniband/core/cq.c, 45:
> [FUNC_PTR]ib_mad_recv_done in __ib_process_cq
> drivers/infiniband/core/cq.c, 77:
> __ib_process_cq in ib_process_cq_direct
This trace doesn't seem right, the CQ used by SRP will never have
ib_mad_recv_done as a function pointer.
Jason
next prev parent reply other threads:[~2018-09-02 20:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-01 12:06 [PATCH] infiniband: core: mad: Fix a sleep-in-atomic-context bug in ib_mad_recv_done() Jia-Ju Bai
2018-09-02 20:32 ` Jason Gunthorpe [this message]
2018-09-03 1:41 ` Jia-Ju Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180902203229.GA13946@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=baijiaju1990@gmail.com \
--cc=bart.vanassche@sandisk.com \
--cc=dledford@redhat.com \
--cc=haakon.bugge@oracle.com \
--cc=hal@mellanox.com \
--cc=ira.weiny@intel.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=parav@mellanox.com \
--cc=pravin.shedge4linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox