From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29D32C43334 for ; Sun, 2 Sep 2018 20:01:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6A9820857 for ; Sun, 2 Sep 2018 20:01:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="EBMmUklY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B6A9820857 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727266AbeICASL (ORCPT ); Sun, 2 Sep 2018 20:18:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:55122 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726978AbeICASL (ORCPT ); Sun, 2 Sep 2018 20:18:11 -0400 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B52D820837; Sun, 2 Sep 2018 20:01:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1535918477; bh=9X1vymjJptQIRzgqrkYRHO2f9s7hwSZ/HX0T2Uw90rk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EBMmUklYI7LNeYW07I9txJ6n9iKCPJ5a9Ta2rTzP4ftDeW7sQQyUl3wIy2YeiI48o p3CT8dEMvKYpjVHPya3tWCFPNg7Hz5cs/kiAHIkbWxtHK5sWJuhLL+7Oi5jEAsn4a2 p6oHtv7yTuDzB6llnWCFXH5ioHXSU/S9KKwW4/G4= Date: Sun, 2 Sep 2018 21:01:09 +0100 From: Jonathan Cameron To: Philipp Rossak Cc: lee.jones@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, maxime.ripard@bootlin.com, wens@csie.org, linux@armlinux.org.uk, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, eugen.hristev@microchip.com, rdunlap@infradead.org, vilhelm.gray@gmail.com, clabbe.montjoie@gmail.com, quentin.schulz@bootlin.com, geert+renesas@glider.be, lukas@wunner.de, icenowy@aosc.io, arnd@arndb.de, broonie@kernel.org, arnaud.pouliquen@st.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v3 05/30] iio: adc: move SUN4I_GPADC_CHANNEL define to header file Message-ID: <20180902210109.7bd4a567@archlinux> In-Reply-To: <20180830154518.29507-6-embed3d@gmail.com> References: <20180830154518.29507-1-embed3d@gmail.com> <20180830154518.29507-6-embed3d@gmail.com> X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 30 Aug 2018 17:44:53 +0200 Philipp Rossak wrote: > We are moving the SUN4I_GPADC_CHANNEL define to the header file. Maxime has raised this point in other patches... Why? Obvious what but I have no idea why you are doing this. Thanks, Jonathan > > Signed-off-by: Philipp Rossak > --- > drivers/iio/adc/sun4i-gpadc-iio.c | 9 --------- > include/linux/mfd/sun4i-gpadc.h | 9 +++++++++ > 2 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/iio/adc/sun4i-gpadc-iio.c b/drivers/iio/adc/sun4i-gpadc-iio.c > index d95dd0fde2a6..666329940e1e 100644 > --- a/drivers/iio/adc/sun4i-gpadc-iio.c > +++ b/drivers/iio/adc/sun4i-gpadc-iio.c > @@ -109,15 +109,6 @@ struct sun4i_gpadc_iio { > struct device *sensor_device; > }; > > -#define SUN4I_GPADC_ADC_CHANNEL(_channel, _name) { \ > - .type = IIO_VOLTAGE, \ > - .indexed = 1, \ > - .channel = _channel, \ > - .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), \ > - .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE), \ > - .datasheet_name = _name, \ > -} > - > static struct iio_map sun4i_gpadc_hwmon_maps[] = { > { > .adc_channel_label = "temp_adc", > diff --git a/include/linux/mfd/sun4i-gpadc.h b/include/linux/mfd/sun4i-gpadc.h > index 139872c2e0fe..54c7c9375c1b 100644 > --- a/include/linux/mfd/sun4i-gpadc.h > +++ b/include/linux/mfd/sun4i-gpadc.h > @@ -90,6 +90,15 @@ > /* 10s delay before suspending the IP */ > #define SUN4I_GPADC_AUTOSUSPEND_DELAY 10000 > > +#define SUN4I_GPADC_ADC_CHANNEL(_channel, _name) { \ > + .type = IIO_VOLTAGE, \ > + .indexed = 1, \ > + .channel = _channel, \ > + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), \ > + .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE), \ > + .datasheet_name = _name, \ > +} > + > struct sun4i_gpadc_dev { > struct device *dev; > struct regmap *regmap;