From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 525ACC43334 for ; Mon, 3 Sep 2018 03:02:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E9A4020857 for ; Mon, 3 Sep 2018 03:02:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="eYo3rYXs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9A4020857 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727459AbeICHU3 (ORCPT ); Mon, 3 Sep 2018 03:20:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:49828 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725903AbeICHU3 (ORCPT ); Mon, 3 Sep 2018 03:20:29 -0400 Received: from dragon (unknown [45.56.155.166]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C7DB820652; Mon, 3 Sep 2018 03:02:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1535943742; bh=Dd4HMtGGDd4b/1mkYiBZvrYSM8HF8G7uSydvqmozXQ0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eYo3rYXsm5LadMa3obBYh2RY6HF1FFsTwc0B9+gwT1fyHhr7IkaYDqrogOWzjknqz p7tc1mzLgVnqymkO4N6vtsT7JLt1QLc0dMp1N8SDlIzEd7EQ+Fp7rrsglnpZvCrTQY G8t+BaOboRgCf1fgcY+HC5wsYhClofMhnVE8q3Wc= Date: Mon, 3 Sep 2018 11:01:12 +0800 From: Shawn Guo To: Yogesh Gaur Cc: linux-mtd@lists.infradead.org, boris.brezillon@bootlin.com, marek.vasut@gmail.com, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, mark.rutland@arm.com, robh@kernel.org, linux-kernel@vger.kernel.org, frieder.schrempf@exceet.de, computersforpeace@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 5/7] arm64: dts: lx2160a: add fspi node property Message-ID: <20180903030110.GI3850@dragon> References: <1535711404-29528-1-git-send-email-yogeshnarayan.gaur@nxp.com> <1535711404-29528-6-git-send-email-yogeshnarayan.gaur@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1535711404-29528-6-git-send-email-yogeshnarayan.gaur@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 31, 2018 at 04:00:02PM +0530, Yogesh Gaur wrote: > Add fspi node property for LX2160A SoC for FlexSPI driver. > Property added for the FlexSPI controller and for the connected > slave device for the LX2160ARDB target. > This is having two SPI-NOR flash device, mt35xu512aba, connected > at CS0 and CS1. > > Signed-off-by: Yogesh Gaur > --- > arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 21 +++++++++++++++++++++ > arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 12 ++++++++++++ > 2 files changed, 33 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts > index 70fad20..3646315 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts > @@ -32,6 +32,27 @@ > status = "okay"; > }; > > +&fspi { > + status = "okay"; Have a newline between property and child node. > + flash0: mt35xu512aba@0 { Generic name for node, and specific name for label. > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "m25p80"; Please take a look at bindings doc jedec,spi-nor.txt on how compatible should be written. > + m25p,fast-read; > + spi-max-frequency = <20000000>; > + reg = <0>; > + }; > + > + flash1: mt35xu512aba@1 { > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "m25p80"; > + m25p,fast-read; > + spi-max-frequency = <20000000>; > + reg = <1>; > + }; > +}; > + > &i2c0 { > status = "okay"; > pca9547@77 { > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > index e35e494..031eb26 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > @@ -568,5 +568,17 @@ > timeout-sec = <30>; > }; > > + fspi: flexspi@20c0000 { > + status = "disabled"; We conventionally put 'status' line at the end of property list. Shawn > + compatible = "nxp,lx2160a-fspi"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x0 0x20c0000 0x0 0x10000>, > + <0x0 0x20000000 0x0 0x10000000>; > + reg-names = "fspi_base", "fspi_mmap"; > + interrupts = <0 25 0x4>; /* Level high type */ > + clocks = <&clockgen 4 3>, <&clockgen 4 3>; > + clock-names = "fspi_en", "fspi"; > + }; > }; > }; > -- > 2.7.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel