RE: [PATCH 0/2] x86/kvm: Enable MCE injection in the guest v2

Ghannam, Yazen
2018-07-06T16:35:08Z

> -----Original Message-----
> From: Borislav Petkov <bp@alien8.de>
> Sent: Thursday, June 28, 2018 1:38 PM
> To: KVM <kvm@vger.kernel.org>
> Cc: Joerg Roedel <joro@8bytes.org>; Radim Krčmář <rkrcmar@redhat.com>;
> Lendacky, Thomas <Thomas.Lendacky@amd.com>; Tony Luck
> <tony.luck@intel.com>; Ghannam, Yazen <Yazen.Ghannam@amd.com>; LKML
> <linux-kernel@vger.kernel.org>
> Subject: [PATCH 0/2] x86/kvm: Enable MCE injection in the guest v2
>
> From: Borislav Petkov <bp@suse.de>
>
> Hi all,
>
> here's v2, dropping patch 3 and incorporating hopefully all of Radim's
> feedback.
>
> Thx.
>
> v1 cover letter:
>
> there's this mce-inject.ko module in the kernel which allows for
> injecting real MCEs and thus test the MCE handling code.
>
> It is doubly useful to be able to inject same MCEs in a guest so that
> testing of the MCE handling code can happen even easier/faster. In order
> to be able to do that on an AMD guest, we need to emulate some bits
> and pieces like the HWCR[McStatusWrEn] bit which allows writes to the
> MCi_STATUS registers without a #GP.
>
> The below does that and with it I'm able to properly inject MCEs in said
> guest.
>
> Borislav Petkov (2):
> kvm/x86: Move MSR_K7_HWCR to svm.c
> x86/kvm: Implement MSR_HWCR support
>
> arch/x86/kvm/svm.c | 20 ++++++++++++++++++++
> arch/x86/kvm/x86.c | 46 +++++++++++++++++++++++++++++++---------------
> 2 files changed, 51 insertions(+), 15 deletions(-)
>

Tested-by: Yazen Ghannam <yazen.ghannam@amd.com>

Thanks!

-Yazen