From: Jiri Olsa <jolsa@redhat.com>
To: Kim Phillips <kim.phillips@arm.com>
Cc: Andi Kleen <andi@firstfloor.org>,
acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Make perf script easier to use for itrace
Date: Mon, 3 Sep 2018 09:31:18 +0200 [thread overview]
Message-ID: <20180903073117.GC24575@krava> (raw)
In-Reply-To: <20180831175453.7378c5dd74d498b6d9002512@arm.com>
On Fri, Aug 31, 2018 at 05:54:53PM -0500, Kim Phillips wrote:
> On Fri, 31 Aug 2018 15:01:56 -0700
> Andi Kleen <andi@firstfloor.org> wrote:
>
> > Also available in
> > git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc.git pt/easy-script-2
> >
> > v1: Initial post
> > v2: Address review comments. Minor fixes to descriptions. Now builds everywhere.
>
> OK, I grabbed the pt/easy-script-2 branch (commit 4c69fd388e17), and
> see build failures for a 'make -C perf' build using gcc version 7.3.0
> (Ubuntu 18.04):
>
> builtin-script.c: In function ‘parse_output_fields’:
> builtin-script.c:2571:22: error: array subscript is above array bounds [-Werror=array-bounds]
> output[j].fields &= ~all_output_options[i].field;
> ^~
> builtin-script.c:2571:22: error: array subscript is above array bounds [-Werror=array-bounds]
> output[j].fields &= ~all_output_options[i].field;
> ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> builtin-script.c:2574:10: error: array subscript is above array bounds [-Werror=array-bounds]
> output[j].user_set = true;
> ~~~~~~^~~
> builtin-script.c:2575:10: error: array subscript is above array bounds [-Werror=array-bounds]
> output[j].wildcard_set = true;
> ~~~~~~^~~
> ...
> util/cs-etm.c: In function ‘cs_etm__process_auxtrace_info’:
> util/cs-etm.c:1436:14: error: ‘struct perf_session’ has no member named ‘itrace_synth’; did you mean ‘itrace_synth_opts’?
> session->itrace_synth.default_no_sample);
> ^~~~~~~~~~~~
> itrace_synth_opts
I think Andi has the new changes in pt/easy-script-3 branch,
just did not update the changelog
jirka
next prev parent reply other threads:[~2018-09-03 7:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 22:01 Make perf script easier to use for itrace Andi Kleen
2018-08-31 22:01 ` [PATCH v2 01/10] perf tools: Report itrace options in help Andi Kleen
2018-08-31 22:01 ` [PATCH v2 02/10] tools, pager: Support overwriting the pager Andi Kleen
2018-08-31 22:01 ` [PATCH v2 03/10] tools, perf, script: Add --insn-trace for instruction decoding Andi Kleen
2018-08-31 22:02 ` [PATCH v2 04/10] perf, tools, script: Allow sym and dso without ip, addr Andi Kleen
2018-09-03 7:15 ` Jiri Olsa
2018-09-03 16:12 ` Andi Kleen
2018-08-31 22:02 ` [PATCH v2 05/10] tools, perf, script: Set user_set/wildcard_set for +- fields in -F Andi Kleen
2018-08-31 22:02 ` [PATCH v2 06/10] perf, tools, script: Implement - for typed fields Andi Kleen
2018-09-03 7:17 ` Jiri Olsa
2018-08-31 22:02 ` [PATCH v2 07/10] perf, tools, script: Print DSO for callindent Andi Kleen
2018-08-31 22:02 ` [PATCH v2 08/10] perf, tools, script: Make itrace script default to all calls Andi Kleen
2018-08-31 22:02 ` [PATCH v2 09/10] tools, perf, script: Add --call-trace and --call-ret-trace Andi Kleen
2018-08-31 22:02 ` [PATCH v2 10/10] tools, perf, script: Implement --graph-function Andi Kleen
2018-09-03 7:51 ` Jiri Olsa
2018-09-03 15:44 ` Andi Kleen
2018-08-31 22:54 ` Make perf script easier to use for itrace Kim Phillips
2018-09-03 7:31 ` Jiri Olsa [this message]
2018-09-03 15:50 ` Andi Kleen
2018-09-03 7:52 ` Jiri Olsa
-- strict thread matches above, loose matches on Subject: below --
2018-09-20 18:05 Andi Kleen
2018-09-18 12:32 Andi Kleen
2018-09-14 3:10 Andi Kleen
2018-09-03 16:22 Andi Kleen
2018-08-29 17:18 Andi Kleen
2018-08-30 8:42 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180903073117.GC24575@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=kim.phillips@arm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox