From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86A64C43334 for ; Mon, 3 Sep 2018 21:38:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E357820869 for ; Mon, 3 Sep 2018 21:38:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E357820869 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lwn.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727361AbeIDCAK (ORCPT ); Mon, 3 Sep 2018 22:00:10 -0400 Received: from ms.lwn.net ([45.79.88.28]:50394 "EHLO ms.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726135AbeIDCAJ (ORCPT ); Mon, 3 Sep 2018 22:00:09 -0400 Received: from lwn.net (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id C276D72A; Mon, 3 Sep 2018 21:38:05 +0000 (UTC) Date: Mon, 3 Sep 2018 15:38:04 -0600 From: Jonathan Corbet To: Heinrich Schuchardt Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] docs: kernel-doc: fix parsing of function pointers Message-ID: <20180903153804.2b091448@lwn.net> In-Reply-To: References: <20180903184153.9368-1-xypron.glpk@gmx.de> <20180903130043.059b2e82@lwn.net> Organization: LWN.net MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 3 Sep 2018 22:29:00 +0200 Heinrich Schuchardt wrote: > >> # pointer-to-function > >> $arg =~ tr/#/,/; > >> - $arg =~ m/[^\(]+\(\*?\s*([\w\.]*)\s*\)/; > > m/[^\(]+\(\*?\s*([\w\.]*)\s*\)/; > ^ > Here we allow for 0..1 asterixes. > > If there is no asterix it is not a function pointer. Why should we care > for this case? GCC seems to allow that asterisk (asterix is an indomitable Gaul :) to be missing; not sure if that's officially allowed by the language or not. I also don't know if any code in the kernel elides it, but *somebody* at some point made it optional, presumably with some reason. It would be instructive to take out that "?" and see what changes happen in a docs build; I'll try to find a moment to do that. jon