* [PATCH v2] media: vimc: implement basic v4l2-ctrls
@ 2018-09-04 1:45 Guilherme Gallo
2018-09-04 6:40 ` Hans Verkuil
0 siblings, 1 reply; 3+ messages in thread
From: Guilherme Gallo @ 2018-09-04 1:45 UTC (permalink / raw)
To: hverkuil, Helen Koike, Mauro Carvalho Chehab, linux-media,
linux-kernel
Cc: lkcamp
Add brightness, contrast, hue and saturation controls in vimc-sensor
Signed-off-by: Guilherme Alcarde Gallo <gagallo7@gmail.com>
Signed-off-by: Guilherme Gallo <gagallo7@gmail.com>
---
drivers/media/platform/vimc/vimc-sensor.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/drivers/media/platform/vimc/vimc-sensor.c b/drivers/media/platform/vimc/vimc-sensor.c
index b2b89315e7ba..edf4c85ae63d 100644
--- a/drivers/media/platform/vimc/vimc-sensor.c
+++ b/drivers/media/platform/vimc/vimc-sensor.c
@@ -317,6 +317,18 @@ static int vimc_sen_s_ctrl(struct v4l2_ctrl *ctrl)
case V4L2_CID_VFLIP:
tpg_s_vflip(&vsen->tpg, ctrl->val);
break;
+ case V4L2_CID_BRIGHTNESS:
+ tpg_s_brightness(&vsen->tpg, ctrl->val);
+ break;
+ case V4L2_CID_CONTRAST:
+ tpg_s_contrast(&vsen->tpg, ctrl->val);
+ break;
+ case V4L2_CID_HUE:
+ tpg_s_hue(&vsen->tpg, ctrl->val);
+ break;
+ case V4L2_CID_SATURATION:
+ tpg_s_saturation(&vsen->tpg, ctrl->val);
+ break;
default:
return -EINVAL;
}
@@ -378,6 +390,14 @@ static int vimc_sen_comp_bind(struct device *comp, struct device *master,
V4L2_CID_VFLIP, 0, 1, 1, 0);
v4l2_ctrl_new_std(&vsen->hdl, &vimc_sen_ctrl_ops,
V4L2_CID_HFLIP, 0, 1, 1, 0);
+ v4l2_ctrl_new_std(&vsen->hdl, &vimc_sen_ctrl_ops,
+ V4L2_CID_BRIGHTNESS, 0, 255, 1, 128);
+ v4l2_ctrl_new_std(&vsen->hdl, &vimc_sen_ctrl_ops,
+ V4L2_CID_CONTRAST, 0, 255, 1, 128);
+ v4l2_ctrl_new_std(&vsen->hdl, &vimc_sen_ctrl_ops,
+ V4L2_CID_HUE, -128, 127, 1, 0);
+ v4l2_ctrl_new_std(&vsen->hdl, &vimc_sen_ctrl_ops,
+ V4L2_CID_SATURATION, 0, 255, 1, 128);
vsen->sd.ctrl_handler = &vsen->hdl;
if (vsen->hdl.error) {
ret = vsen->hdl.error;
--
2.13.6
Changes in v2:
- Added brightness, hue and saturation controls.
- Fixed the standard values for hue control.
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] media: vimc: implement basic v4l2-ctrls
2018-09-04 1:45 [PATCH v2] media: vimc: implement basic v4l2-ctrls Guilherme Gallo
@ 2018-09-04 6:40 ` Hans Verkuil
2018-09-04 22:54 ` Guilherme Alcarde Gallo
0 siblings, 1 reply; 3+ messages in thread
From: Hans Verkuil @ 2018-09-04 6:40 UTC (permalink / raw)
To: Guilherme Gallo, Helen Koike, Mauro Carvalho Chehab, linux-media,
linux-kernel
Cc: lkcamp
Hi Guilherme,
On 09/04/2018 03:45 AM, Guilherme Gallo wrote:
> Add brightness, contrast, hue and saturation controls in vimc-sensor
>
> Signed-off-by: Guilherme Alcarde Gallo <gagallo7@gmail.com>
> Signed-off-by: Guilherme Gallo <gagallo7@gmail.com>
Looks good, but you have (probably unintended) two Signed-off-by lines.
Just let me know which one I should use and I'll drop the other one.
Regards,
Hans
> ---
> drivers/media/platform/vimc/vimc-sensor.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/media/platform/vimc/vimc-sensor.c b/drivers/media/platform/vimc/vimc-sensor.c
> index b2b89315e7ba..edf4c85ae63d 100644
> --- a/drivers/media/platform/vimc/vimc-sensor.c
> +++ b/drivers/media/platform/vimc/vimc-sensor.c
> @@ -317,6 +317,18 @@ static int vimc_sen_s_ctrl(struct v4l2_ctrl *ctrl)
> case V4L2_CID_VFLIP:
> tpg_s_vflip(&vsen->tpg, ctrl->val);
> break;
> + case V4L2_CID_BRIGHTNESS:
> + tpg_s_brightness(&vsen->tpg, ctrl->val);
> + break;
> + case V4L2_CID_CONTRAST:
> + tpg_s_contrast(&vsen->tpg, ctrl->val);
> + break;
> + case V4L2_CID_HUE:
> + tpg_s_hue(&vsen->tpg, ctrl->val);
> + break;
> + case V4L2_CID_SATURATION:
> + tpg_s_saturation(&vsen->tpg, ctrl->val);
> + break;
> default:
> return -EINVAL;
> }
> @@ -378,6 +390,14 @@ static int vimc_sen_comp_bind(struct device *comp, struct device *master,
> V4L2_CID_VFLIP, 0, 1, 1, 0);
> v4l2_ctrl_new_std(&vsen->hdl, &vimc_sen_ctrl_ops,
> V4L2_CID_HFLIP, 0, 1, 1, 0);
> + v4l2_ctrl_new_std(&vsen->hdl, &vimc_sen_ctrl_ops,
> + V4L2_CID_BRIGHTNESS, 0, 255, 1, 128);
> + v4l2_ctrl_new_std(&vsen->hdl, &vimc_sen_ctrl_ops,
> + V4L2_CID_CONTRAST, 0, 255, 1, 128);
> + v4l2_ctrl_new_std(&vsen->hdl, &vimc_sen_ctrl_ops,
> + V4L2_CID_HUE, -128, 127, 1, 0);
> + v4l2_ctrl_new_std(&vsen->hdl, &vimc_sen_ctrl_ops,
> + V4L2_CID_SATURATION, 0, 255, 1, 128);
> vsen->sd.ctrl_handler = &vsen->hdl;
> if (vsen->hdl.error) {
> ret = vsen->hdl.error;
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] media: vimc: implement basic v4l2-ctrls
2018-09-04 6:40 ` Hans Verkuil
@ 2018-09-04 22:54 ` Guilherme Alcarde Gallo
0 siblings, 0 replies; 3+ messages in thread
From: Guilherme Alcarde Gallo @ 2018-09-04 22:54 UTC (permalink / raw)
To: hverkuil
Cc: Helen Koike, Mauro Carvalho Chehab, linux-media, linux-kernel,
lkcamp
On Tue, Sep 4, 2018 at 3:40 AM Hans Verkuil <hverkuil@xs4all.nl> wrote:
>
> Hi Guilherme,
Hi Hans.
>
> On 09/04/2018 03:45 AM, Guilherme Gallo wrote:
> > Add brightness, contrast, hue and saturation controls in vimc-sensor
> >
> > Signed-off-by: Guilherme Alcarde Gallo <gagallo7@gmail.com>
> > Signed-off-by: Guilherme Gallo <gagallo7@gmail.com>
>
> Looks good, but you have (probably unintended) two Signed-off-by lines.
> Just let me know which one I should use and I'll drop the other one.
Yeah, it was unintended. Sorry for that.
Please pick this one:
Signed-off-by: Guilherme Alcarde Gallo <gagallo7@gmail.com>
Thanks for pointing that.
Guilherme
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-04 22:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-04 1:45 [PATCH v2] media: vimc: implement basic v4l2-ctrls Guilherme Gallo
2018-09-04 6:40 ` Hans Verkuil
2018-09-04 22:54 ` Guilherme Alcarde Gallo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox