From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B9CDC433F5 for ; Wed, 5 Sep 2018 09:15:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FB14206BA for ; Wed, 5 Sep 2018 09:15:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2FB14206BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=opensource.cirrus.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726999AbeIENoZ (ORCPT ); Wed, 5 Sep 2018 09:44:25 -0400 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:43834 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725862AbeIENoZ (ORCPT ); Wed, 5 Sep 2018 09:44:25 -0400 Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w859EFHR003041; Wed, 5 Sep 2018 04:15:06 -0500 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.cirrus.com Received: from mail3.cirrus.com ([87.246.76.56]) by mx0b-001ae601.pphosted.com with ESMTP id 2m7q6p58xc-1; Wed, 05 Sep 2018 04:15:05 -0500 Received: from EX17.ad.cirrus.com (ex17.ad.cirrus.com [172.20.9.81]) by mail3.cirrus.com (Postfix) with ESMTP id CC663611C8B4; Wed, 5 Sep 2018 04:16:50 -0500 (CDT) Received: from imbe.wolfsonmicro.main (198.61.95.81) by EX17.ad.cirrus.com (172.20.9.81) with Microsoft SMTP Server id 14.3.408.0; Wed, 5 Sep 2018 10:15:04 +0100 Received: from imbe.wolfsonmicro.main (imbe.wolfsonmicro.main [198.61.95.81]) by imbe.wolfsonmicro.main (8.14.4/8.14.4) with ESMTP id w859F4vO018819; Wed, 5 Sep 2018 10:15:04 +0100 Date: Wed, 5 Sep 2018 10:15:04 +0100 From: Charles Keepax To: Colin King CC: Lee Jones , , , Subject: Re: [PATCH] mfd: arizona: make array mclk_name static, shrinks object size Message-ID: <20180905091504.GB1653@imbe.wolfsonmicro.main> References: <20180904141553.28000-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20180904141553.28000-1-colin.king@canonical.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=839 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1809050099 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 04, 2018 at 03:15:53PM +0100, Colin King wrote: > From: Colin Ian King > > Don't populate the array mclk_name on the stack but instead make it > static. Makes the object code smaller by 23 bytes: > > Before: > text data bss dec hex filename > 38050 11604 64 49718 c236 linux/drivers/mfd/arizona-core.o > > After: > text data bss dec hex filename > 38027 11604 64 49695 c21f linux/drivers/mfd/arizona-core.o > > (gcc version 8.2.0 x86_64) > > Signed-off-by: Colin Ian King > --- Acked-by: Charles Keepax Thanks, Charles