From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E56DC433F5 for ; Thu, 6 Sep 2018 11:04:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 20C7820652 for ; Thu, 6 Sep 2018 11:04:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20C7820652 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728570AbeIFPjK (ORCPT ); Thu, 6 Sep 2018 11:39:10 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:39820 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727625AbeIFPjK (ORCPT ); Thu, 6 Sep 2018 11:39:10 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 13BAD7DAC2; Thu, 6 Sep 2018 11:04:15 +0000 (UTC) Received: from krava (unknown [10.43.17.49]) by smtp.corp.redhat.com (Postfix) with SMTP id BF9742166B41; Thu, 6 Sep 2018 11:04:13 +0000 (UTC) Date: Thu, 6 Sep 2018 13:04:13 +0200 From: Jiri Olsa To: Alexey Budankov Cc: Ingo Molnar , Peter Zijlstra , Arnaldo Carvalho de Melo , Alexander Shishkin , Namhyung Kim , Andi Kleen , linux-kernel Subject: Re: [PATCH v7 2/2]: perf record: enable asynchronous trace writing Message-ID: <20180906110413.GF8248@krava> References: <1fc1fc5b-a8cc-2b05-d43c-692e58855c81@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Thu, 06 Sep 2018 11:04:15 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Thu, 06 Sep 2018 11:04:15 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'jolsa@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 05, 2018 at 10:39:25AM +0300, Alexey Budankov wrote: SNIP > + > static int process_synthesized_event(struct perf_tool *tool, > union perf_event *event, > struct perf_sample *sample __maybe_unused, > @@ -130,12 +215,28 @@ static int process_synthesized_event(struct perf_tool *tool, > return record__write(rec, event, event->header.size); > } > > -static int record__pushfn(void *to, void *bf, size_t size) > +static int record__pushfn(void *to, struct aiocb *cblock, void *data, size_t size) > { > + off_t off; > struct record *rec = to; > + int ret, trace_fd = rec->session->data->file.fd; > > rec->samples++; > - return record__write(rec, bf, size); > + > + off = > + lseek(trace_fd, 0, SEEK_CUR); please keep that on the same line.. also, please run this patchset through the scripts/checkpatch.pl don't worry about the 'line over 80 characters' errors, but the rest will be nice to have ;-) jirka