Re: [PATCH v5 08/16] x86/apic: add modern APIC support for Hygon

Pu Wen
2018-09-05T08:08:44Z

On 2018/9/5 2:33, Borislav Petkov wrote:
> On Wed, Aug 29, 2018 at 08:44:30PM +0800, Pu Wen wrote:
...
>> + if ((boot_cpu_data.x86_vendor == X86_VENDOR_AMD &&
>> + boot_cpu_data.x86 >= 0xf) ||
>> + boot_cpu_data.x86_vendor == X86_VENDOR_HYGON)
>> return 1;
>
> Those compound conditionals are not nice to read. Just add yours
> underneath:
>
> if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD &&
> boot_cpu_data.x86 >= 0xf)
> return 1;
>
> if (boot_cpu_data.x86_vendor == X86_VENDOR_HYGON)
> return 1;
>
> Do that where applicable and where it makes sense, syntax-wise to have a
> separate vendor == HYGON check in the other patches too.

That's OK, will check other patches and split the compound conditionals
where it's possible.

--
Thanks,
Pu Wen