Re: [PATCH v5 15/16] driver/edac: enable Hygon support to AMD64 EDAC driver

Pu Wen
2018-09-05T13:03:29Z

On 2018/9/5 18:44, Borislav Petkov wrote:
> Subject should be:
>
> EDAC, amd64: Add Hygon Dhyana support

Thanks for the correction.

>> + case 0x18:
>> + fam_type = &family_types[HYGON_F18_CPUS];
>> + pvt->ops = &family_types[HYGON_F18_CPUS].ops;
>> + break;
>> +
>
> You can use the F17_CPUS array element here and overwrite the ->ctl_name
> string only. No need to define [HYGON_F18_CPUS] above... yet.

All right, the way reusing F17_CPUS will also minimize the code
modification.

>> +#define PCI_DEVICE_ID_HYGON_18H_DF_F0 0x1460
>> +#define PCI_DEVICE_ID_HYGON_18H_DF_F6 0x1466
>
> As in the previous patch - use the AMD defines.

Will remove them in next version of patches.

--
Regards,
Pu Wen