From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC360C43334 for ; Thu, 6 Sep 2018 18:45:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8E73A20659 for ; Thu, 6 Sep 2018 18:45:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E73A20659 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730524AbeIFXWU (ORCPT ); Thu, 6 Sep 2018 19:22:20 -0400 Received: from mga06.intel.com ([134.134.136.31]:7763 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727126AbeIFXWU (ORCPT ); Thu, 6 Sep 2018 19:22:20 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Sep 2018 11:45:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,339,1531810800"; d="scan'208";a="71152763" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.20]) by orsmga008.jf.intel.com with ESMTP; 06 Sep 2018 11:45:03 -0700 Date: Thu, 6 Sep 2018 11:45:03 -0700 From: Sean Christopherson To: Borislav Petkov Cc: Brijesh Singh , x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Tom Lendacky , Thomas Gleixner , "H. Peter Anvin" , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH v5 5/5] x86/kvm: Avoid dynamic allocation of pvclock data when SEV is active Message-ID: <20180906184503.GA4570@linux.intel.com> References: <1536234182-2809-1-git-send-email-brijesh.singh@amd.com> <1536234182-2809-6-git-send-email-brijesh.singh@amd.com> <20180906122423.GA11144@zn.tnic> <20180906135041.GB32336@linux.intel.com> <20180906144342.GB11144@zn.tnic> <20180906145639.GA1522@linux.intel.com> <20180906151938.GD11144@zn.tnic> <20180906155452.GC1522@linux.intel.com> <20180906183334.GF11144@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180906183334.GF11144@zn.tnic> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 06, 2018 at 08:33:34PM +0200, Borislav Petkov wrote: > On Thu, Sep 06, 2018 at 08:54:52AM -0700, Sean Christopherson wrote: > > My thought was that we could simply define a second array for the SEV > > case to statically allocate for NR_CPUS since __decrypted has a big > > chunk of memory that would be ununsed anyways[1]. And since the second > > array is only used for SEV it can be freed if !SEV. > > Lemme see if I get it straight: > > __decrypted: > > 4K > > __decrypted_XXX: > > ((num_possible_cpus() * 32) / 4K) pages > > __decrypted_end: > > Am I close? Yep, though because the 4k chunk in __decrypted is @hv_clock_boot that's used for cpus 0-127, __decrypted_XXX would effectively be: (((num_possible_cpus() * 32) / 4k) - 1) pages