From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D6C5C433F5 for ; Fri, 7 Sep 2018 08:56:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 21FC02077C for ; Fri, 7 Sep 2018 08:56:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21FC02077C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728118AbeIGNgq (ORCPT ); Fri, 7 Sep 2018 09:36:46 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49532 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727679AbeIGNgq (ORCPT ); Fri, 7 Sep 2018 09:36:46 -0400 Received: from localhost (ip-213-127-74-90.ip.prioritytelecom.net [213.127.74.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id D224DF47; Fri, 7 Sep 2018 08:56:47 +0000 (UTC) Date: Fri, 7 Sep 2018 10:56:45 +0200 From: Greg Kroah-Hartman To: Chunfeng Yun Cc: Mathias Nyman , Felipe Balbi , Matthias Brugger , Sean Wang , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, stable@vger.kernel.org Subject: Re: [PATCH v2] usb: xhci: fix interrupt transfer error happened on MTK platforms Message-ID: <20180907085645.GA17270@kroah.com> References: <20180907074251.GA2079@kroah.com> <1536309826.32173.45.camel@mhfsdcap03> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1536309826.32173.45.camel@mhfsdcap03> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 07, 2018 at 04:43:46PM +0800, Chunfeng Yun wrote: > Hi, > > On Fri, 2018-09-07 at 09:42 +0200, Greg Kroah-Hartman wrote: > > On Fri, Sep 07, 2018 at 03:29:12PM +0800, Chunfeng Yun wrote: > > > The MTK xHCI controller use some reserved bytes in endpoint context for > > > bandwidth scheduling, so need keep them in xhci_endpoint_copy(); > > > > If they are "reserved" shouldn't they be properly named? And by using > > reserved bytes, isn't that a spec violation? > It indeed violates the spec, "they shall be treated by system software > as Reserved and Opaque", and it's a quirk of the MTK xHCI controller. So as the "system software" here, we should just ignore them otherwise we violate the spec? :) Anyway, that's fine, no objection from me for the patch, thanks. greg k-h