Re: [PATCH v2 2/3] arm64: lib: use C string functions with KASAN enabled.

Will Deacon
2018-10-29T10:29:19Z

On Thu, Sep 20, 2018 at 04:56:30PM +0300, Andrey Ryabinin wrote:
> ARM64 has asm implementation of memchr(), memcmp(), str[r]chr(),
> str[n]cmp(), str[n]len(). KASAN don't see memory accesses in asm
> code, thus it can potentially miss many bugs.
>
> Ifdef out __HAVE_ARCH_* defines of these functions when KASAN is
> enabled, so the generic implementations from lib/string.c will be used.
>
> We can't just remove the asm functions because efistub uses them.
> And we can't have two non-weak functions either, so declare the asm
> functions as weak.
>
> Reported-by: Kyeongdon Kim <kyeongdon.kim@lge.com>
> Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
> ---
> Changes since v1:
> - Use WEAK() instead of .weak
>
> arch/arm64/include/asm/string.h | 14 ++++++++------
> arch/arm64/kernel/arm64ksyms.c | 7 +++++--
> arch/arm64/lib/memchr.S | 2 +-
> arch/arm64/lib/memcmp.S | 2 +-
> arch/arm64/lib/strchr.S | 2 +-
> arch/arm64/lib/strcmp.S | 2 +-
> arch/arm64/lib/strlen.S | 2 +-
> arch/arm64/lib/strncmp.S | 2 +-
> arch/arm64/lib/strnlen.S | 2 +-
> arch/arm64/lib/strrchr.S | 2 +-
> 10 files changed, 21 insertions(+), 16 deletions(-)

Acked-by: Will Deacon <will.deacon@arm.com>

Please post these again after the merge window and we'll figure out how to
get them queued.

Will