From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C80CC4321E for ; Sat, 8 Sep 2018 15:54:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1242E2086B for ; Sat, 8 Sep 2018 15:54:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="VlJp71oY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1242E2086B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727672AbeIHUkm (ORCPT ); Sat, 8 Sep 2018 16:40:42 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:50820 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726880AbeIHUkm (ORCPT ); Sat, 8 Sep 2018 16:40:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=C7PqeCu5hpsaBQ7e/D3QcL9bW0Cbeipnu4nsNVxDHIw=; b=VlJp71oY1kWTli1zflcoVO/Po OIts/FvLu4YXxhtvoQv1iiMWynHEJ/6s34MLyfLp2VzhRNCvqoSo4sPBURiQvhEPfgYGiRBjelMAK ZNXo/pHoX31pNXaHIG5ZEoQcuJxVoGzIf4jReb88VeDCx95AnkI03OSAd9SI4YwANLtY5St5IYOUC KTwl26BQC6tFa6merMK+O7rsjh56NjHePDLhFWZVYjSL3GRSZP/8JQ9ALlc+O3T4KXsgNCCUKHotf uGMEl00wRNwDmFiqnlLGfcC7M/IzLChTk0TKopS9U80EEhd379JpuM6+1W0r39/mSH1/o8AcLh62j 373WoUVEA==; Received: from willy by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fyfZ0-0000Th-VG; Sat, 08 Sep 2018 15:54:22 +0000 Date: Sat, 8 Sep 2018 08:54:22 -0700 From: Matthew Wilcox To: Johannes Weiner Cc: Alexey Dobriyan , linux-kernel@vger.kernel.org, vjitta@codeaurora.org, sumit.semwal@linaro.org, rientjes@google.com, mhocko@kernel.org, mgorman@techsingularity.net, labbott@redhat.com, iamjoonsoo.kim@lge.com, guro@fb.com, cl@linux.com, vbabka@suse.cz Subject: Re: + mm-slab-shorten-kmalloc-cache-names-for-large-sizes.patch added to -mm tree Message-ID: <20180908155422.GA26807@bombadil.infradead.org> References: <20180906224849.1JOWr%akpm@linux-foundation.org> <20180907195816.GA28375@avx2> <20180908140306.GB17637@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180908140306.GB17637@cmpxchg.org> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 08, 2018 at 10:03:06AM -0400, Johannes Weiner wrote: > On Fri, Sep 07, 2018 at 10:58:16PM +0300, Alexey Dobriyan wrote: > > On Thu, Sep 06, 2018 at 03:48:49PM -0700, akpm@linux-foundation.org wrote: > > > - {"kmalloc-1024", 1024}, {"kmalloc-2048", 2048}, > > > - {"kmalloc-4096", 4096}, {"kmalloc-8192", 8192}, > > > - {"kmalloc-16384", 16384}, {"kmalloc-32768", 32768}, > > > - {"kmalloc-65536", 65536}, {"kmalloc-131072", 131072}, > > > - {"kmalloc-262144", 262144}, {"kmalloc-524288", 524288}, > > > - {"kmalloc-1048576", 1048576}, {"kmalloc-2097152", 2097152}, > > > - {"kmalloc-4194304", 4194304}, {"kmalloc-8388608", 8388608}, > > > - {"kmalloc-16777216", 16777216}, {"kmalloc-33554432", 33554432}, > > > - {"kmalloc-67108864", 67108864} > > > + {"kmalloc-1k", 1024}, {"kmalloc-2k", 2048}, > > > + {"kmalloc-4k", 4096}, {"kmalloc-8k", 8192}, > > > + {"kmalloc-16k", 16384}, {"kmalloc-32k", 32768}, > > > + {"kmalloc-64k", 65536}, {"kmalloc-128k", 131072}, > > > + {"kmalloc-256k", 262144}, {"kmalloc-512k", 524288}, > > > + {"kmalloc-1M", 1048576}, {"kmalloc-2M", 2097152}, > > > + {"kmalloc-4M", 4194304}, {"kmalloc-8M", 8388608}, > > > + {"kmalloc-16M", 16777216}, {"kmalloc-32M", 33554432}, > > > + {"kmalloc-64M", 67108864} > > > > I'd rather use KB and MB suffixes or at least capital 'K'. > > I like k and M better. k and M work for me too. It we were going to be anal then we should go with the IEC standard of KiB and MiB, but we're trying to make /proc/slabinfo a little less ugly, and so we have 16 characters to work with. "dma-kmalloc-256KiB" is 18 characters. The obvious place to lose two characters is the "iB" which are implicit; we know we're measuring bytes and the binary nature is assumed in this context of memory bytes (not storage bytes). "dma-kmalloc-256k" is better.