From: "Angus Ainslie (Purism)" <angus@akkea.ca>
To: groeck7@gmail.com
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
"Angus Ainslie (Purism)" <angus@akkea.ca>
Subject: [PATCH v2] usb: typec: get the vbus source and charge values from the devicetree
Date: Sun, 9 Sep 2018 12:05:31 -0600 [thread overview]
Message-ID: <20180909180531.28092-1-angus@akkea.ca> (raw)
In-Reply-To: <20180906192644.24587-1-angus@akkea.ca>
If the board is being powered by USB disabling the source and sink
can remove power from the board. Allow the source and sink to be
initallized based on devicetree values.
Changed since V1:
use devicetree values instead of hardcoded initialization.
Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca>
---
.../bindings/connector/usb-connector.txt | 4 ++++
drivers/usb/typec/tcpm.c | 14 +++++++++++---
2 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/connector/usb-connector.txt b/Documentation/devicetree/bindings/connector/usb-connector.txt
index 8855bfcfd778..afe851a713c3 100644
--- a/Documentation/devicetree/bindings/connector/usb-connector.txt
+++ b/Documentation/devicetree/bindings/connector/usb-connector.txt
@@ -22,6 +22,10 @@ Optional properties for usb-c-connector:
or Try.SRC, should be "sink" for Try.SNK or "source" for Try.SRC.
- data-role: should be one of "host", "device", "dual"(DRD) if typec
connector supports USB data.
+- init-vbus-source: set the initalization value for vbus-source to true.
+ If this property is not present the initial value will be false.
+- init-vbus-charge: set the initalization value for vbus-charge to true.
+ If this property is not present the initial value will be false.
Required properties for usb-c-connector with power delivery support:
- source-pdos: An array of u32 with each entry providing supported power
diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c
index ca7bedb46f7f..7f5d4f209e07 100644
--- a/drivers/usb/typec/tcpm.c
+++ b/drivers/usb/typec/tcpm.c
@@ -2462,9 +2462,7 @@ static int tcpm_init_vbus(struct tcpm_port *port)
{
int ret;
- ret = port->tcpc->set_vbus(port->tcpc, false, false);
- port->vbus_source = false;
- port->vbus_charge = false;
+ ret = port->tcpc->set_vbus(port->tcpc, port->vbus_source, port->vbus_charge);
return ret;
}
@@ -4266,6 +4264,16 @@ static int tcpm_fw_get_caps(struct tcpm_port *port,
return -EINVAL;
port->port_type = port->typec_caps.type;
+ if (fwnode_property_present(fwnode, "init-vbus-source"))
+ port->vbus_source = true;
+ else
+ port->vbus_source = false;
+
+ if (fwnode_property_present(fwnode, "init-vbus-charge"))
+ port->vbus_charge = true;
+ else
+ port->vbus_charge = false;
+
if (port->port_type == TYPEC_PORT_SNK)
goto sink;
--
2.17.1
next prev parent reply other threads:[~2018-09-09 18:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 19:26 [PATCH] usb: typec: don't disable sink or source on initialization Angus Ainslie (Purism)
2018-09-07 9:39 ` Sergei Shtylyov
2018-09-07 10:34 ` Heikki Krogerus
2018-09-07 12:55 ` Guenter Roeck
2018-09-09 14:08 ` Angus Ainslie
2018-09-09 14:20 ` Guenter Roeck
2018-09-09 14:36 ` Angus Ainslie
2018-09-09 14:43 ` Guenter Roeck
2018-09-09 18:05 ` Angus Ainslie (Purism) [this message]
2018-09-09 19:52 ` [PATCH v2] usb: typec: get the vbus source and charge values from the devicetree Guenter Roeck
2018-09-09 20:09 ` Angus Ainslie
2018-09-10 7:35 ` Heikki Krogerus
2018-09-10 13:11 ` Angus Ainslie
2018-09-10 13:43 ` Guenter Roeck
2018-09-10 14:32 ` Angus Ainslie
2018-09-10 13:49 ` Heikki Krogerus
2018-09-11 14:59 ` [PATCH v3] " Angus Ainslie (Purism)
2018-09-11 15:33 ` Guenter Roeck
2018-09-12 16:08 ` Angus Ainslie
2018-09-12 16:32 ` Guenter Roeck
2018-09-13 7:27 ` Peter Chen
2018-09-13 11:10 ` Angus Ainslie
2018-09-13 17:34 ` Guenter Roeck
2018-09-14 0:38 ` Jun Li
2018-09-14 0:25 ` Jun Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180909180531.28092-1-angus@akkea.ca \
--to=angus@akkea.ca \
--cc=gregkh@linuxfoundation.org \
--cc=groeck7@gmail.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).