From: Greg Kroah-Hartman <greg@kroah.com>
To: Ray Clinton <mr.ray.clinton@gmail.com>
Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] staging: comedi: Correct multiline dereference as per TODO
Date: Mon, 10 Sep 2018 10:33:22 +0200 [thread overview]
Message-ID: <20180910083322.GA29149@kroah.com> (raw)
In-Reply-To: <CAPMnawtav+8OX4+iPA+RDBXJZ7OR==noksxxtNLzzTTCPcb-NQ@mail.gmail.com>
On Thu, Aug 30, 2018 at 01:32:09PM -0400, Ray Clinton wrote:
> Hi,
>
> I've been working on the correcting the checkpatch.pl failures found in
> staging/drivers/staging/comedi of 4.18.0 and have a few patches to submit
> for review.
>
> The files that I changed are:
>
> drivers/dt3000.c
> drivers/ni_labpc_common.c
> drivers/ni_mio_common.c
> drivers/dt3000.c
>
> While there were a few warnings/checks checkpatch.pl brings up the only
> one that the Internet told me was ok to work on were dereferences that
> happened over multiple lines. For each of the files above that was the issue
> and it was always due to the author trying to stay within the 80 character
> line width limitation. I did my best to remove the warning while keeping the
> code readable.
>
> **PLEASE**: any feedback on what I could do better in the patches, in the
> emails, anything, would be much appreciated.
You sent 4 patches with the identical Subject: line, which isn't
something that I can apply. Please make the subjects unique, as they
all do unique things, right?
thanks,
greg k-h
prev parent reply other threads:[~2018-09-10 8:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 17:32 [PATCH 0/4] staging: comedi: Correct multiline dereference as per TODO Ray Clinton
2018-09-10 8:33 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910083322.GA29149@kroah.com \
--to=greg@kroah.com \
--cc=abbotti@mev.co.uk \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mr.ray.clinton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox