From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7165DC4321E for ; Mon, 10 Sep 2018 12:32:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1B9D620866 for ; Mon, 10 Sep 2018 12:32:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B9D620866 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728374AbeIJR0Z (ORCPT ); Mon, 10 Sep 2018 13:26:25 -0400 Received: from mx2.suse.de ([195.135.220.15]:40814 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728087AbeIJR0Y (ORCPT ); Mon, 10 Sep 2018 13:26:24 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 764C8AFE3; Mon, 10 Sep 2018 12:32:31 +0000 (UTC) Date: Mon, 10 Sep 2018 14:32:30 +0200 From: Borislav Petkov To: Brijesh Singh Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Tom Lendacky , Thomas Gleixner , "H. Peter Anvin" , Paolo Bonzini , Sean Christopherson , Radim =?utf-8?B?S3LEjW3DocWZ?= Subject: Re: [PATCH v6 2/5] x86/mm: fix sme_populate_pgd() to update page flags Message-ID: <20180910123230.GF21815@zn.tnic> References: <1536343050-18532-1-git-send-email-brijesh.singh@amd.com> <1536343050-18532-3-git-send-email-brijesh.singh@amd.com> <20180910113645.GB21815@zn.tnic> <4001638e-6627-7d42-2e72-21c48484022a@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4001638e-6627-7d42-2e72-21c48484022a@amd.com> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 10, 2018 at 07:28:08AM -0500, Brijesh Singh wrote: > Based on your advice I  was going to submit this series to stable > separately. This particular issue is not affecting anyone right now. The > only user to this function is sme_kernel_encrypt() which never updates > the PTE/PMD entries.  I can update the commit message like this this to > clarify it. > > Enhance the sme_populate_pgd() to update page flags if the PMD/PTE entry > already exists. Agreed, except you still need the Fixes: tag to go with the patch. And that Fixes: tag should point to the patch which added the checks you're removing, I'd say. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --