From: Lee Jones <lee.jones@linaro.org>
To: Benson Leung <bleung@google.com>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Guenter Roeck <groeck@chromium.org>,
kernel@collabora.com
Subject: Re: [PATCH 2/2] mfd: cros_ec: Fix and improve kerneldoc comments.
Date: Mon, 10 Sep 2018 14:47:45 +0100 [thread overview]
Message-ID: <20180910134745.GO28860@dell> (raw)
In-Reply-To: <CANLzEkvuNYS4q_bATF1kz205dzfrjzEkRZ0MaT71-Cd46-D0fA@mail.gmail.com>
On Mon, 10 Sep 2018, Benson Leung wrote:
> On Mon, Sep 10, 2018 at 5:12 PM Lee Jones <lee.jones@linaro.org> wrote:
> >
> > On Fri, 07 Sep 2018, Benson Leung wrote:
> >
> > > Hi Enric,
> > >
> > > On Wed, Jul 18, 2018 at 06:09:56PM +0200, Enric Balletbo i Serra wrote:
> > > > cros-ec includes inside the MFD subsystem, specially the file
> > > > cros_ec_commands.h, has been modified several times and it has grown a
> > > > lot, unfortunately, we didn't have care too much about the documentation.
> > > > This patch tries to improve the documentation and also fixes all the
> > > > issues reported by kerneldoc script.
> > > >
> > > > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > >
> > > Applied, thanks.
> >
> > If applying patches from other subsystems, you need to wait for an
> > appropriate Ack before applying. Please send me a succinct
> > pull-request for this patch, so that we might avoid potential conflict
> > at merge time.
>
> Ok Lee, sorry about that. Actually this hasn't landed in my for-next
> branch yet so no conflict has happened yet. I will send you a PR
> shortly.
No worries, it happens.
The PR is to avoid merge conflicts at "merge time" i.e. when Linus
merges everything into Mainline during the merge window.
Appreciate your help.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-09-10 13:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 16:09 [PATCH 0/2] mfd: platform/chrome: some more cleanups between these subsystems Enric Balletbo i Serra
2018-07-18 16:09 ` [PATCH 1/2] platform/chrome: Move mfd/cros_ec_lpc* includes to drivers/platform Enric Balletbo i Serra
2018-09-07 7:32 ` Benson Leung
2018-07-18 16:09 ` [PATCH 2/2] mfd: cros_ec: Fix and improve kerneldoc comments Enric Balletbo i Serra
2018-09-07 7:54 ` Benson Leung
2018-09-10 9:12 ` Lee Jones
2018-09-10 9:13 ` Benson Leung
2018-09-10 13:47 ` Lee Jones [this message]
2018-08-27 10:39 ` [PATCH 0/2] mfd: platform/chrome: some more cleanups between these subsystems Enric Balletbo Serra
2018-09-06 9:55 ` Benson Leung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910134745.GO28860@dell \
--to=lee.jones@linaro.org \
--cc=bleung@google.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox