From: Lee Jones <lee.jones@linaro.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: linux-kernel@vger.kernel.org, u.kleine-koenig@pengutronix.de,
andrey.gusakov@cogentembedded.com, cphealy@gmail.com,
Fabio Estevam <fabio.estevam@nxp.com>
Subject: Re: [PATCH] mfd: mc13xxx-core: Fix PMIC shutdown when reading ADC values
Date: Mon, 10 Sep 2018 16:29:05 +0100 [thread overview]
Message-ID: <20180910152905.GB28860@dell> (raw)
In-Reply-To: <1535486560-16267-1-git-send-email-festevam@gmail.com>
On Tue, 28 Aug 2018, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> When trying to read any MC13892 ADC channel on a imx51-babbage board:
>
> # cat /sys/class/hwmon/hwmon0/device/in7_input
>
> The MC13892 PMIC shutdowns completely.
>
> After debugging this issue and comparing the MC13892 and MC13783
> initializations done in the vendor kernel, it was noticed that the
> CHRGRAWDIV bit of the ADC0 register was not being set.
>
> This bit is set by default after power on, but the driver was
> clearing it.
>
> After setting this bit it is possible to read the ADC values correctly.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> drivers/mfd/mc13xxx-core.c | 3 ++-
> include/linux/mfd/mc13xxx.h | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2018-09-10 15:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 20:02 [PATCH] mfd: mc13xxx-core: Fix PMIC shutdown when reading ADC values Fabio Estevam
2018-08-28 20:33 ` Chris Healy
2018-09-10 15:29 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910152905.GB28860@dell \
--to=lee.jones@linaro.org \
--cc=andrey.gusakov@cogentembedded.com \
--cc=cphealy@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox