From: Christoph Hellwig <hch@lst.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Christoph Hellwig <hch@lst.de>,
iommu@lists.linux-foundation.org,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
Paul Burton <paul.burton@mips.com>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] dma-mapping: move the dma_coherent flag to struct device
Date: Tue, 11 Sep 2018 08:46:36 +0200 [thread overview]
Message-ID: <20180911064636.GA6214@lst.de> (raw)
In-Reply-To: <20180910161350.GA10380@kroah.com>
On Mon, Sep 10, 2018 at 06:13:50PM +0200, Greg Kroah-Hartman wrote:
> > +#if defined(CONFIG_ARCH_HAS_SYNC_DMA_FOR_DEVICE) || \
> > + defined(CONFIG_ARCH_HAS_SYNC_DMA_FOR_CPU) || \
> > + defined(CONFIG_ARCH_HAS_SYNC_DMA_FOR_CPU_ALL)
> > + bool dma_coherent:1;
> > +#endif
>
> It's just one bit, why not always have it enabled here? If the arch
> uses it or doesn't, no big deal.
>
> Or are you using this to "catch" arches that mess something up?
Yes, that is the intent - I don't want architectures to accidentally
set it while not selecting the non-coherent infrastructure, as it
won't have an effect.
next prev parent reply other threads:[~2018-09-11 6:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 6:05 merge dma_direct_ops and dma_noncoherent_ops v2 Christoph Hellwig
2018-09-10 6:05 ` [PATCH 1/5] MIPS: don't select DMA_MAYBE_COHERENT from DMA_PERDEV_COHERENT Christoph Hellwig
2018-09-10 6:05 ` [PATCH 2/5] dma-mapping: move the dma_coherent flag to struct device Christoph Hellwig
2018-09-10 15:19 ` Robin Murphy
2018-09-10 15:47 ` Christoph Hellwig
2018-09-10 16:06 ` Robin Murphy
2018-09-11 6:48 ` Christoph Hellwig
2018-09-11 6:58 ` Christoph Hellwig
2018-09-10 16:13 ` Greg Kroah-Hartman
2018-09-11 6:46 ` Christoph Hellwig [this message]
2018-09-11 8:19 ` Greg Kroah-Hartman
2018-09-10 6:05 ` [PATCH 3/5] dma-mapping: merge direct and noncoherent ops Christoph Hellwig
2018-09-10 6:05 ` [PATCH 4/5] dma-mapping: consolidate the dma mmap implementations Christoph Hellwig
2018-09-10 6:05 ` [PATCH 5/5] dma-mapping: support non-coherent devices in dma_common_get_sgtable Christoph Hellwig
[not found] <20180827145032.9522-1-hch@lst.de>
2018-08-27 14:50 ` [PATCH 2/5] dma-mapping: move the dma_coherent flag to struct device Christoph Hellwig
2018-08-31 20:11 ` Paul Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180911064636.GA6214@lst.de \
--to=hch@lst.de \
--cc=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=m.szyprowski@samsung.com \
--cc=paul.burton@mips.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox