From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65FF3C04ABB for ; Tue, 11 Sep 2018 08:19:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1CB2C20854 for ; Tue, 11 Sep 2018 08:19:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CB2C20854 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726608AbeIKNSH (ORCPT ); Tue, 11 Sep 2018 09:18:07 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38686 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726408AbeIKNSH (ORCPT ); Tue, 11 Sep 2018 09:18:07 -0400 Received: from localhost (ip-213-127-74-90.ip.prioritytelecom.net [213.127.74.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 74596B9E; Tue, 11 Sep 2018 08:19:55 +0000 (UTC) Date: Tue, 11 Sep 2018 10:19:52 +0200 From: Greg Kroah-Hartman To: Christoph Hellwig Cc: iommu@lists.linux-foundation.org, Marek Szyprowski , Robin Murphy , Paul Burton , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] dma-mapping: move the dma_coherent flag to struct device Message-ID: <20180911081952.GA17267@kroah.com> References: <20180910060533.27172-1-hch@lst.de> <20180910060533.27172-3-hch@lst.de> <20180910161350.GA10380@kroah.com> <20180911064636.GA6214@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180911064636.GA6214@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 11, 2018 at 08:46:36AM +0200, Christoph Hellwig wrote: > On Mon, Sep 10, 2018 at 06:13:50PM +0200, Greg Kroah-Hartman wrote: > > > +#if defined(CONFIG_ARCH_HAS_SYNC_DMA_FOR_DEVICE) || \ > > > + defined(CONFIG_ARCH_HAS_SYNC_DMA_FOR_CPU) || \ > > > + defined(CONFIG_ARCH_HAS_SYNC_DMA_FOR_CPU_ALL) > > > + bool dma_coherent:1; > > > +#endif > > > > It's just one bit, why not always have it enabled here? If the arch > > uses it or doesn't, no big deal. > > > > Or are you using this to "catch" arches that mess something up? > > Yes, that is the intent - I don't want architectures to accidentally > set it while not selecting the non-coherent infrastructure, as it > won't have an effect. Ok, fine with me: Acked-by: Greg Kroah-Hartman