Re: [PATCH v4 03/16] sched/core: uclamp: add CPU's clamp groups accounting

Patrick Bellasi
2018-09-14T13:41:36Z

On 14-Sep 13:52, Peter Zijlstra wrote:
> On Fri, Sep 14, 2018 at 10:07:51AM +0100, Patrick Bellasi wrote:
> > On 13-Sep 21:12, Peter Zijlstra wrote:
> > > On Tue, Aug 28, 2018 at 02:53:11PM +0100, Patrick Bellasi wrote:
> > > > +static inline void uclamp_cpu_get_id(struct task_struct *p,
> > > > + struct rq *rq, int clamp_id)
> > > > +{
> > > > + struct uclamp_group *uc_grp;
> > > > + struct uclamp_cpu *uc_cpu;
> > > > + int clamp_value;
> > > > + int group_id;
> > > > +
> > > > + /* Every task must reference a clamp group */
> > > > + group_id = p->uclamp[clamp_id].group_id;
> > >
> > > > +}
> > > > +
> > > > +static inline void uclamp_cpu_put_id(struct task_struct *p,
> > > > + struct rq *rq, int clamp_id)
> > > > +{
> > > > + struct uclamp_group *uc_grp;
> > > > + struct uclamp_cpu *uc_cpu;
> > > > + unsigned int clamp_value;
> > > > + int group_id;
> > > > +
> > > > + /* New tasks don't have a previous clamp group */
> > > > + group_id = p->uclamp[clamp_id].group_id;
> > > > + if (group_id == UCLAMP_NOT_VALID)
> > > > + return;
> > >
> > > *confused*, so on enqueue they must have a group_id, but then on dequeue
> > > they might no longer have?
> >
> > Why not ?
>
> That's what it says on the tin, right? enqueue: "every task must reference clamp
> group" while on dequeue: "new tasks don't have a (previous) clamp group"
> and we check for NOT_VALID.

Oh, right... I've got confused me too since I was looking @enqueue.

You right, @dequeue we always a group_id. The check @dequeue time was
required only before v3 because of the way defaults (i.e. no clamps)
was tracked. Will remove it in v5, thanks!

BTW, my previous explanation was also incorrect, since the logic for
init_task initialization is:

uc_se->group_id = UCLAMP_NOT_VALID;
uclamp_group_get(value)

where the first assignment is required just to inform uclamp_group_get()
that we don't need to uclamp_group_put() a previous (non existing at
init time) clamp group.

Thus, at the end of the two instructions above we end up with an
init_task which has a !UCLAMP_NOT_VALID group id, which is then
cloned by forked tasks.

Cheers,
Patrick

--
#include <best/regards.h>

Patrick Bellasi