From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B12FDC46469 for ; Wed, 12 Sep 2018 13:11:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 65F0E206BB for ; Wed, 12 Sep 2018 13:11:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 65F0E206BB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727002AbeILSQH (ORCPT ); Wed, 12 Sep 2018 14:16:07 -0400 Received: from foss.arm.com ([217.140.101.70]:59372 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726606AbeILSQH (ORCPT ); Wed, 12 Sep 2018 14:16:07 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E4BB680D; Wed, 12 Sep 2018 06:11:39 -0700 (PDT) Received: from edgewater-inn.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B63563F703; Wed, 12 Sep 2018 06:11:39 -0700 (PDT) Received: by edgewater-inn.cambridge.arm.com (Postfix, from userid 1000) id 969131AE3231; Wed, 12 Sep 2018 14:11:56 +0100 (BST) Date: Wed, 12 Sep 2018 14:11:56 +0100 From: Will Deacon To: linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, arnd@arndb.de, linux@dominikbrodowski.net, ebiederm@xmission.com, akpm@linux-foundation.org, viro@zeniv.linux.org.uk, oleg@redhat.com, steve.mcintyre@arm.com, dave.martin@arm.com, christian@brauner.io, ldv@altlinux.org Subject: Re: [RESEND PATCH 0/2] Don't use SIGMINSTKSZ when enforcing alternative signal stack size for compat tasks Message-ID: <20180912131156.GC29880@arm.com> References: <1536158083-30166-1-git-send-email-will.deacon@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1536158083-30166-1-git-send-email-will.deacon@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, [+ more people from get_maintainers.pl] On Wed, Sep 05, 2018 at 03:34:41PM +0100, Will Deacon wrote: > This is a resend of: > > http://lists.infradead.org/pipermail/linux-arm-kernel/2018-July/593559.html > > now based on 4.19-rc2. > > The Debian folks have observed a failure in the 32-bit arm glibc testsuite > when running under a 64-bit kernel. They tracked this down to sigaltstack(2) > enforcing the alternative signal stack to be at least SIGMINSTKSZ bytes, > which is higher for native arm64 tasks than compat 32-bit tasks. > > These patches resolve the issue by allowing an architecture to define > COMPAT_SIGMINSTKSZ for compat tasks, which is then used by the sigaltstack > checking code. > > Feedback welcome, Any comments on this, please? I'd really like to get this fixed, since Debian have an outstanding issue without these patches merged. I'm happy to take them via arm64, but would really like an Ack on the changes to signal.c first... Thanks, Will > Will Deacon (2): > signal: Introduce COMPAT_SIGMINSTKSZ for use in compat_sys_sigaltstack > arm64: compat: Provide definition for COMPAT_SIGMINSTKSZ > > arch/arm64/include/asm/compat.h | 1 + > include/linux/compat.h | 3 +++ > kernel/signal.c | 14 +++++++++----- > 3 files changed, 13 insertions(+), 5 deletions(-) > > -- > 2.1.4 >