From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] tools: Remove conflicting BITS_PER_LONG define
Date: Wed, 12 Sep 2018 16:21:29 -0300 [thread overview]
Message-ID: <20180912192129.GB13738@kernel.org> (raw)
In-Reply-To: <20180912190107.GA5502@redhat.com>
Em Wed, Sep 12, 2018 at 04:01:07PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Wed, Sep 12, 2018 at 07:02:32PM +0200, Alexander Sverdlin escreveu:
> > CC .../tools/objtool/builtin-check.o
> > ...
> > In file included from .../tools/arch/x86/include/uapi/asm/bitsperlong.h:11:0,
> > from .../tools/include/asm-generic/bitops/__ffs.h:6,
> > from .../tools/include/asm-generic/bitops.h:16,
> > from .../tools/include/linux/bitops.h:35,
> > from .../tools/include/linux/hashtable.h:13,
> > from elf.h:24,
> > from check.h:22,
> > from builtin-check.c:30:
> > .../tools/include/asm-generic/bitsperlong.h:8:0: error: "BITS_PER_LONG" redefined [-Werror]
> > #define BITS_PER_LONG (__CHAR_BIT__ * __SIZEOF_LONG__)
> >
> > Include <asm/bitsperlong.h> instead as other headers do.
>
> Please try test building all tools in tools/
>
> This broke make -C tools/perf/
Also, where is the build of objtool failing?
[acme@jouet linux]$ git log --oneline -3
96eddb810b14 (HEAD -> master, torvalds/master) Merge tag 'riscv-for-linus-4.19-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/palmer/riscv-linux
aeb5427218a7 Merge tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi
5e335542de83 Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid
[acme@jouet linux]$ make -C tools/objtool/
make: Entering directory '/home/acme/git/linux/tools/objtool'
make -C /home/acme/git/linux/tools/build CFLAGS= LDFLAGS= fixdep
make[1]: Entering directory '/home/acme/git/linux/tools/build'
HOSTCC fixdep.o
HOSTLD fixdep-in.o
LINK fixdep
make[1]: Leaving directory '/home/acme/git/linux/tools/build'
make -C /home/acme/git/linux/tools/lib/subcmd/ OUTPUT=/home/acme/git/linux/tools/objtool/
make[1]: Entering directory '/home/acme/git/linux/tools/lib/subcmd'
make -C /home/acme/git/linux/tools/build CFLAGS= LDFLAGS= /home/acme/git/linux/tools/objtool/fixdep
HOSTCC /home/acme/git/linux/tools/objtool/fixdep.o
HOSTLD /home/acme/git/linux/tools/objtool/fixdep-in.o
LINK /home/acme/git/linux/tools/objtool/fixdep
CC /home/acme/git/linux/tools/objtool/exec-cmd.o
CC /home/acme/git/linux/tools/objtool/help.o
CC /home/acme/git/linux/tools/objtool/pager.o
CC /home/acme/git/linux/tools/objtool/parse-options.o
CC /home/acme/git/linux/tools/objtool/run-command.o
CC /home/acme/git/linux/tools/objtool/sigchain.o
CC /home/acme/git/linux/tools/objtool/subcmd-config.o
LD /home/acme/git/linux/tools/objtool/libsubcmd-in.o
AR /home/acme/git/linux/tools/objtool/libsubcmd.a
make[1]: Leaving directory '/home/acme/git/linux/tools/lib/subcmd'
make[1]: Entering directory '/home/acme/git/linux/tools/objtool'
make[2]: Entering directory '/home/acme/git/linux/tools/objtool'
GEN arch/x86/lib/inat-tables.c
CC arch/x86/decode.o
LD arch/x86/objtool-in.o
make[2]: Leaving directory '/home/acme/git/linux/tools/objtool'
CC builtin-check.o
CC builtin-orc.o
CC check.o
CC orc_gen.o
CC orc_dump.o
CC elf.o
CC special.o
CC objtool.o
CC libstring.o
CC str_error_r.o
LD objtool-in.o
make[1]: Leaving directory '/home/acme/git/linux/tools/objtool'
LINK objtool
make: Leaving directory '/home/acme/git/linux/tools/objtool'
[acme@jouet linux]$
Now building it without -C:
$ make -C tools/clean
[acme@jouet objtool]$ make
make -C /home/acme/git/linux/tools/build CFLAGS= LDFLAGS= fixdep
make[1]: Entering directory '/home/acme/git/linux/tools/build'
HOSTCC fixdep.o
HOSTLD fixdep-in.o
LINK fixdep
make[1]: Leaving directory '/home/acme/git/linux/tools/build'
make -C /home/acme/git/linux/tools/lib/subcmd/ OUTPUT=/home/acme/git/linux/tools/objtool/
make[1]: Entering directory '/home/acme/git/linux/tools/lib/subcmd'
make -C /home/acme/git/linux/tools/build CFLAGS= LDFLAGS= /home/acme/git/linux/tools/objtool/fixdep
HOSTCC /home/acme/git/linux/tools/objtool/fixdep.o
HOSTLD /home/acme/git/linux/tools/objtool/fixdep-in.o
LINK /home/acme/git/linux/tools/objtool/fixdep
CC /home/acme/git/linux/tools/objtool/exec-cmd.o
CC /home/acme/git/linux/tools/objtool/help.o
CC /home/acme/git/linux/tools/objtool/pager.o
CC /home/acme/git/linux/tools/objtool/parse-options.o
CC /home/acme/git/linux/tools/objtool/run-command.o
CC /home/acme/git/linux/tools/objtool/sigchain.o
CC /home/acme/git/linux/tools/objtool/subcmd-config.o
LD /home/acme/git/linux/tools/objtool/libsubcmd-in.o
AR /home/acme/git/linux/tools/objtool/libsubcmd.a
make[1]: Leaving directory '/home/acme/git/linux/tools/lib/subcmd'
make[1]: Entering directory '/home/acme/git/linux/tools/objtool'
make[2]: Entering directory '/home/acme/git/linux/tools/objtool'
GEN arch/x86/lib/inat-tables.c
CC arch/x86/decode.o
LD arch/x86/objtool-in.o
make[2]: Leaving directory '/home/acme/git/linux/tools/objtool'
CC builtin-check.o
CC builtin-orc.o
CC check.o
CC orc_gen.o
CC orc_dump.o
CC elf.o
CC special.o
CC objtool.o
CC libstring.o
CC str_error_r.o
LD objtool-in.o
make[1]: Leaving directory '/home/acme/git/linux/tools/objtool'
LINK objtool
[acme@jouet objtool]$
So where is the failure?
- Arnaldo
next prev parent reply other threads:[~2018-09-12 19:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 17:02 [PATCH] tools: Remove conflicting BITS_PER_LONG define Alexander Sverdlin
2018-09-12 19:01 ` Arnaldo Carvalho de Melo
2018-09-12 19:21 ` Arnaldo Carvalho de Melo [this message]
2018-09-19 12:28 ` Alexander Sverdlin
2018-09-19 13:03 ` Arnaldo Carvalho de Melo
2018-09-19 15:25 ` Alexander Sverdlin
2018-09-24 8:33 ` Alexander Sverdlin
2018-09-19 12:16 ` Alexander Sverdlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180912192129.GB13738@kernel.org \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=alexander.sverdlin@nokia.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox