From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C88BDC070C3 for ; Wed, 12 Sep 2018 21:58:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6446D20C0A for ; Wed, 12 Sep 2018 21:58:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6446D20C0A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727946AbeIMDEd (ORCPT ); Wed, 12 Sep 2018 23:04:33 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60554 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726838AbeIMDEd (ORCPT ); Wed, 12 Sep 2018 23:04:33 -0400 Received: from localhost (ip-213-127-74-90.ip.prioritytelecom.net [213.127.74.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id E9B0FD3E; Wed, 12 Sep 2018 21:58:02 +0000 (UTC) Date: Wed, 12 Sep 2018 23:57:59 +0200 From: Greg KH To: Dan Williams Cc: Dave Jiang , Vishal L Verma , "Du, Fan" , linux-nvdimm , Linux Kernel Mailing List , Al Viro Subject: Re: [PATCH] uio: fix is_source param for check_copy_size() in copy_to_iter_mcsafe() Message-ID: <20180912215759.GA3000@kroah.com> References: <153617950046.33664.13445188581267552601.stgit@djiang5-desk3.ch.intel.com> <20180912074850.GA362@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 12, 2018 at 02:51:53PM -0700, Dan Williams wrote: > On Wed, Sep 12, 2018 at 12:48 AM, Greg KH wrote: > > On Wed, Sep 05, 2018 at 01:31:40PM -0700, Dave Jiang wrote: > >> copy_to_iter_mcsafe() is passing in the is_source parameter as "false" > >> to check_copy_size(). This is different than what copy_to_iter() does. > >> Also, the addr parameter passed to check_copy_size() is the source so > >> therefore we should be passing in "true" instead. > >> > >> Fixes: 8780356ef630 ("x86/asm/memcpy_mcsafe: Define copy_to_iter_mcsafe()") > >> Cc: Fan Du > >> Reported-by: Wenwei Tao > >> Signed-off-by: Dave Jiang > >> Reviewed-by: Vishal Verma > >> Cc: stable > >> --- > >> include/linux/uio.h | 2 +- > > > > I am not the maintainer of this file, sorry, please work with the -mm > > developers for this. > > Likely this is get_maintainer.pl's fault: > > $ ./scripts/get_maintainer.pl -f include/linux/uio.h > Greg Kroah-Hartman (maintainer:USERSPACE I/O (UIO)) > linux-kernel@vger.kernel.org (open list) > > Maybe a MAINTAINERS update like the following is warranted, because I > don't think -mm developers are right either, Al seems to be authority > on iov_iter apis: > > diff --git a/MAINTAINERS b/MAINTAINERS > index d870cb57c887..0018e19b4d8e 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -15344,13 +15344,18 @@ F: arch/x86/um/ > F: fs/hostfs/ > F: fs/hppfs/ > > +USERSPACE ACCESS (uaccess, copy_{to,from}_iter) > +M: Alexander Viro > +S: Maintained > +F: include/linux/uio*.h > +F: lib/iov_iter.c > + > USERSPACE I/O (UIO) > M: Greg Kroah-Hartman > S: Maintained > T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git > F: Documentation/driver-api/uio-howto.rst > F: drivers/uio/ > -F: include/linux/uio*.h Don't drop that line, uio_driver.h is what it should just say, right? thanks, greg k-h