From: Jiri Olsa <jolsa@redhat.com>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Hendrik Brueckner <brueckner@linux.vnet.ibm.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Compiler flags for libapi and libtraceevent
Date: Thu, 13 Sep 2018 10:04:39 +0200 [thread overview]
Message-ID: <20180913080439.GA24224@krava> (raw)
In-Reply-To: <7cfcd0da8aba77488feb7403055596d434772545.camel@decadent.org.uk>
On Tue, Sep 11, 2018 at 04:06:46AM +0100, Ben Hutchings wrote:
> I noticed that tools/lib/api/Makefile has these conditional
> assignments, similar to tools/perf/Makefile.config:
>
> ifeq ($(DEBUG),0)
> ifeq ($(CC_NO_CLANG), 0)
> CFLAGS += -O3
> else
> CFLAGS += -O6
> endif
> endif
>
> ifeq ($(DEBUG),0)
> CFLAGS += -D_FORTIFY_SOURCE
> endif
>
> But it doesn't set DEBUG to 0 by default, and nothing under tools/perf
> exports its value of CFLAGS or DEBUG.
hum, AFAICS tools/perf/Makefile.perf exports CFLAGS:
export srctree OUTPUT RM CC CXX LD AR CFLAGS CXXFLAGS V BISON FLEX AWK
jirka
>
> tools/lib/traceevent/Makefile doesn't seem to have any logic to enable
> optimisation or Fortify.
>
> Shouldn't these libraries both have optimisations and Fortify turned on
> by default, like perf itself?
>
> Ben.
>
> --
> Ben Hutchings
> Computers are not intelligent. They only think they are.
>
prev parent reply other threads:[~2018-09-13 8:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 3:06 Compiler flags for libapi and libtraceevent Ben Hutchings
2018-09-13 8:04 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180913080439.GA24224@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ben@decadent.org.uk \
--cc=brueckner@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox