From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73F88FC617E for ; Thu, 13 Sep 2018 17:35:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E83221502 for ; Thu, 13 Sep 2018 15:57:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SXJLvC0Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E83221502 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728357AbeIMVHN (ORCPT ); Thu, 13 Sep 2018 17:07:13 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:33195 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728268AbeIMVHM (ORCPT ); Thu, 13 Sep 2018 17:07:12 -0400 Received: by mail-pl1-f194.google.com with SMTP id b30-v6so2811922pla.0; Thu, 13 Sep 2018 08:57:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=7I7b1oiADODjqJq5oO3cBiJvL9bgHNSH2mVfOfs7amI=; b=SXJLvC0Qwq+NkUWu6q22/hjYwdPCAMRycaII4HUVioJNq5YCZTX0po8LM6+wiQpfs6 X8+bmzebkn4XJSMaxtZxhaF1ePgnDSIDsyH62/lzadfT0yzdHKxqpee4DdCa10hWg6Ot zSHWJHnBkF3XLE0Vgd/UOz4mJUH9aj7cx0CuzD22bFw3FdengoIcANZaXCPVNzKvdTZ8 yfl7QnKsgrSWkohT5/tPIMvT9SGcpjHEnUdOaq++IuXLc5ZLwVq9Yp0gRa3PmSt/X3Y7 iHk1v9n+GCw+dtJbu7jBtLUn5ismtCkqcdEx/ZF/0+94xVeLrtav1dMDfwp+H3S01OwJ 3nrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=7I7b1oiADODjqJq5oO3cBiJvL9bgHNSH2mVfOfs7amI=; b=KPKnGnN4ZjvQ09CI5r+r//82fWPIUcWUP/RdBU5LPauYS0TvK6dB9YhpYJzt2KvWpW LyCobB2AT8KR0gRNBmOwe2kvv/CLTVJfHQp/bnFoQ6XpdztK7G3Ap23q081ZTzFdRb+X uhXyfwYLGBLQd17KWCN7W+IlSk7LdtP9hvIXEgqZLEqV2Lm2qifu7wv2RlVhecmKeI+d Dv0oD4VJo3yxoby1MHIgT3ug0yt8v5mODtvt7aPpoyEcGwp+dmSpogCH/6ekf9cWBdFS wveV4dI9xuCGHvqPHxdFjBnsozcJ0E4Lx3tv7VPqYIUvXBhv2hMW0JYWdjbIbiWfvnSs WYdQ== X-Gm-Message-State: APzg51CUBbBy8hwi7Icr+XAUgR9Hlm8uVIkMGf8HbYPLZ0rnX2waUrw6 RwlpVYadPb3aSM0mCHG4WSA= X-Google-Smtp-Source: ANB0VdYDvTswa0fSP+eZ4K1ZIAi86JETceU3igNqoWw6S3WXRCE02aNlcePEFxRGa9FhafcW+FuyQg== X-Received: by 2002:a17:902:d898:: with SMTP id b24-v6mr7838892plz.218.1536854225831; Thu, 13 Sep 2018 08:57:05 -0700 (PDT) Received: from localhost (108-223-40-66.lightspeed.sntcca.sbcglobal.net. [108.223.40.66]) by smtp.gmail.com with ESMTPSA id i75-v6sm6661858pgc.20.2018.09.13.08.57.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Sep 2018 08:57:04 -0700 (PDT) Date: Thu, 13 Sep 2018 08:57:03 -0700 From: Guenter Roeck To: =?iso-8859-1?Q?C=E9dric?= Le Goater Cc: Jae Hyun Yoo , Joel Stanley , linux-aspeed@lists.ozlabs.org, Vernon Mauery , OpenBMC Maillist , Brendan Higgins , Linux Kernel Mailing List , linux-i2c@vger.kernel.org, jarkko.nikula@linux.intel.com, Linux ARM , James Feist Subject: Re: [PATCH i2c-next v6] i2c: aspeed: Handle master/slave combined irq events properly Message-ID: <20180913155703.GA22605@roeck-us.net> References: <20180911233302.GA18799@roeck-us.net> <5698ca34-14c9-8d05-c4e6-5acf85ff9d14@linux.intel.com> <20180912013449.GA12612@roeck-us.net> <7fd98646-fb5a-be4d-ce37-84b74e0fa8b3@linux.intel.com> <20180912195844.GA6893@roeck-us.net> <20180912203059.GA18201@roeck-us.net> <3f86e75f-1502-eae8-0633-d087937111c8@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 13, 2018 at 05:48:59PM +0200, Cédric Le Goater wrote: > On 09/13/2018 03:33 PM, Guenter Roeck wrote: [ ... ] > >>>   /* > >>>    * The state machine needs some refinement. It is only used to track > >>>    * invalid STOP commands for the moment. > >>> @@ -188,7 +215,7 @@ static void aspeed_i2c_bus_handle_cmd(AspeedI2CBus *bus, uint64_t value) > >>>   { > >>>       bus->cmd &= ~0xFFFF; > >>>       bus->cmd |= value & 0xFFFF; > >>> -    bus->intr_status = 0;> +    bus->intr_status &= I2CD_INTR_RX_DONE; > >> > >> it deserves a comment to understand which scenario we are trying to handle. > >>    > > > > Ok. FWIW, I wonder if intr_status should be touched here in the first place, > > but I neither have the hardware nor a datasheet, so I don't know if any bits > > are auto-cleared. > > I just pushed a patch on my branch with some more explanation : > > https://github.com/legoater/qemu/commits/aspeed-3.1 > That seems to suggest that none of the status bits auto-clears, and that the above code clearing intr_status should be removed entirely. Am I missing something ? Thanks, Guenter