From: Greg KH <gregkh@linuxfoundation.org>
To: rkir@google.com
Cc: linux-kernel@vger.kernel.org, tkjos@google.com
Subject: Re: [PATCH 04/20] platform: goldfish: pipe: Separate the host interface to a separate header
Date: Fri, 14 Sep 2018 15:29:38 +0200 [thread overview]
Message-ID: <20180914132938.GA16982@kroah.com> (raw)
In-Reply-To: <20180827182315.126345-4-rkir@google.com>
On Mon, Aug 27, 2018 at 11:22:59AM -0700, rkir@google.com wrote:
> --- /dev/null
> +++ b/drivers/platform/goldfish/goldfish_pipe_qemu.h
> @@ -0,0 +1,112 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (C) 2018 Google, Inc.
> + *
> + * This software is licensed under the terms of the GNU General Public
> + * License version 2, as published by the Free Software Foundation, and
> + * may be copied, distributed, and modified under those terms.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
When you have a SPDX line, you do not also need the boilerplate license
text in this file as well. So you can remove that please. A later
patch is fine.
thanks,
greg k-h
next prev parent reply other threads:[~2018-09-14 13:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 18:22 [PATCH 01/20] platform: goldfish: pipe: Fix comments to fit 80 columns rkir
2018-08-27 18:22 ` [PATCH 02/20] platform: goldfish: pipe: Update license rkir
2018-08-27 18:22 ` [PATCH 03/20] platform: goldfish: pipe: Move an opening brace to the next line rkir
2018-08-27 18:22 ` [PATCH 04/20] platform: goldfish: pipe: Separate the host interface to a separate header rkir
2018-09-14 13:29 ` Greg KH [this message]
2018-08-27 18:23 ` [PATCH 05/20] platform: goldfish: pipe: Update the comment for GFP_ATOMIC rkir
2018-08-27 18:23 ` [PATCH 06/20] platform: goldfish: pipe: Fail compilation if structs are too large rkir
2018-08-27 18:23 ` [PATCH 07/20] platform: goldfish: pipe: Replace an array of 1 with a variable rkir
2018-09-14 13:30 ` Greg KH
2018-09-14 16:42 ` Roman Kiryanov
2018-09-14 19:20 ` Greg KH
2018-08-27 18:23 ` [PATCH 08/20] platform: goldfish: pipe: Replace pr_ with dev_ for logging rkir
2018-08-27 18:23 ` [PATCH 09/20] platform: goldfish: pipe: Add blank lines to separate struct members rkir
2018-08-27 18:23 ` [PATCH 10/20] platform: goldfish: pipe: Remove a redundant variable rkir
2018-08-27 18:23 ` [PATCH 11/20] platform: goldfish: pipe: Replace two code blocks with a function call rkir
2018-08-27 18:23 ` [PATCH 12/20] platform: goldfish: pipe: Remove reduntant casting rkir
2018-08-27 18:23 ` [PATCH 13/20] platform: goldfish: pipe: Remove a blank line before '}' rkir
2018-08-27 18:23 ` [PATCH 14/20] platform: goldfish: pipe: Rename 'wakeBit' to 'wake_bit' rkir
2018-08-27 18:23 ` [PATCH 15/20] platform: goldfish: pipe: Remove reduntant casting to (void) rkir
2018-08-27 18:23 ` [PATCH 16/20] platform: goldfish: pipe: Rename goldfish_x to goldfish_pipe_x rkir
2018-08-27 18:23 ` [PATCH 17/20] platform: goldfish: pipe: Fix lines to not end an opening bracket rkir
2018-08-27 18:23 ` [PATCH 18/20] platform: goldfish: pipe: Fix alignment to match parenthesis rkir
2018-08-27 18:23 ` [PATCH 19/20] platform: goldfish: pipe: Move logical ops to the end of the prev line rkir
2018-08-27 18:23 ` [PATCH 20/20] platform: goldfish: pipe: Replace "x==NULL" to "!x" rkir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180914132938.GA16982@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkir@google.com \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox