From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC866ECDFD0 for ; Fri, 14 Sep 2018 18:17:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 89B7220833 for ; Fri, 14 Sep 2018 18:17:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="wTLGrzJk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89B7220833 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728067AbeINXdC (ORCPT ); Fri, 14 Sep 2018 19:33:02 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:35074 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726849AbeINXdC (ORCPT ); Fri, 14 Sep 2018 19:33:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=44dUNiLnfgmtXHXeLazPAYh1nAxcCnWMZBdH9TE5eIA=; b=wTLGrzJkVGQdq3C22rFSzAUVnX+A66ljJiXHuo/rddxS9deAhSHO6TiJtuzcjCuLPuVLVQp7J1mrTj475YSg0+VJVCM0OsWMTf5EVM0MGK+DC38Wlf6+Cr0EJh5S3CJLX8x456oi/kfFsb3PHhHsDBIU8ZVsOwr3tXHXrqJpMwU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.84_2) (envelope-from ) id 1g0sec-0006jI-4H; Fri, 14 Sep 2018 20:17:18 +0200 Date: Fri, 14 Sep 2018 20:17:18 +0200 From: Andrew Lunn To: Qing Huang Cc: Leon Romanovsky , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, tariqt@mellanox.com, davem@davemloft.net Subject: Re: [PATCH] net/mlx4_core: print firmware version during driver loading Message-ID: <20180914181718.GD3811@lunn.ch> References: <20180914002514.27571-1-qing.huang@oracle.com> <20180914044314.GC5257@mtr-leonro.mtl.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 14, 2018 at 10:15:48AM -0700, Qing Huang wrote: > The FW version is actually a very crucial piece of information and only > printed once here > when the driver is loaded. People tend to get confused when switching > multiple FW files > back and forth without running separate utility tools, especially at > customer sites. > IMHO, this information is very useful and only takes up very little log file > space. :-) Why not use ethtool -i ? $ sudo ethtool -i eth0 driver: r8169 version: 2.3LK-NAPI firmware-version: rtl8168g-2_0.0.1 02/06/13 Andrew