From: Greg KH <gregkh@linuxfoundation.org>
To: Pablo Pellecchia <pablo9891@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] Staging: wlan-ng: Solved Coding Style issues
Date: Sun, 16 Sep 2018 22:08:26 +0200 [thread overview]
Message-ID: <20180916200826.GA22689@kroah.com> (raw)
In-Reply-To: <20180916193911.8191-1-pablo9891@gmail.com>
On Sun, Sep 16, 2018 at 04:39:11PM -0300, Pablo Pellecchia wrote:
> Solved parenthesis alignment issues throw by checkpatch.pl
>
> Signed-off-by: Pablo Pellecchia <pablo9891@gmail.com>
> ---
> drivers/staging/wlan-ng/cfg80211.c | 40 ++++++++++++++++++--------------------
> 1 file changed, 19 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> index d4cf09b11e33..38bf555a8d3e 100644
> --- a/drivers/staging/wlan-ng/cfg80211.c
> +++ b/drivers/staging/wlan-ng/cfg80211.c
> @@ -234,8 +234,8 @@ static int prism2_set_default_key(struct wiphy *wiphy, struct net_device *dev,
> int result = 0;
>
> result = prism2_domibset_uint32(wlandev,
> - DIDmib_dot11smt_dot11PrivacyTable_dot11WEPDefaultKeyID,
> - key_index);
> + DIDmib_dot11smt_dot11PrivacyTable_dot11WEPDefaultKeyID,
> + key_index);
And now you violate the line length rule :(
Which is why the code looks like it does, what you should really do is
fix up that horridly long variable name. That will fix this properly.
Can you do that instead?
thanks,
greg k-h
prev parent reply other threads:[~2018-09-16 20:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-16 19:39 [PATCH 1/4] Staging: wlan-ng: Solved Coding Style issues Pablo Pellecchia
2018-09-16 20:08 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180916200826.GA22689@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pablo9891@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox