From: Sasha Levin <Alexander.Levin@microsoft.com>
To: "stable@vger.kernel.org" <stable@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Mikulas Patocka <mpatocka@redhat.com>,
Will Deacon <will.deacon@arm.com>,
Sasha Levin <Alexander.Levin@microsoft.com>
Subject: [PATCH AUTOSEL 4.9 15/57] arm64: fix infinite stacktrace
Date: Mon, 17 Sep 2018 03:03:52 +0000 [thread overview]
Message-ID: <20180917030340.378-15-alexander.levin@microsoft.com> (raw)
In-Reply-To: <20180917030340.378-1-alexander.levin@microsoft.com>
From: Mikulas Patocka <mpatocka@redhat.com>
[ Upstream commit 7e7df71fd57ff2894d96abb0080922bf39460a79 ]
I've got this infinite stacktrace when debugging another problem:
[ 908.795225] INFO: rcu_preempt detected stalls on CPUs/tasks:
[ 908.796176] 1-...!: (1 GPs behind) idle=952/1/4611686018427387904 softirq=1462/1462 fqs=355
[ 908.797692] 2-...!: (1 GPs behind) idle=f42/1/4611686018427387904 softirq=1550/1551 fqs=355
[ 908.799189] (detected by 0, t=2109 jiffies, g=130, c=129, q=235)
[ 908.800284] Task dump for CPU 1:
[ 908.800871] kworker/1:1 R running task 0 32 2 0x00000022
[ 908.802127] Workqueue: writecache-writeabck writecache_writeback [dm_writecache]
[ 908.820285] Call trace:
[ 908.824785] __switch_to+0x68/0x90
[ 908.837661] 0xfffffe00603afd90
[ 908.844119] 0xfffffe00603afd90
[ 908.850091] 0xfffffe00603afd90
[ 908.854285] 0xfffffe00603afd90
[ 908.863538] 0xfffffe00603afd90
[ 908.865523] 0xfffffe00603afd90
The machine just locked up and kept on printing the same line over and
over again. This patch fixes it.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
---
arch/arm64/kernel/stacktrace.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c
index 0cc01e0d38eb..40b2680748f8 100644
--- a/arch/arm64/kernel/stacktrace.c
+++ b/arch/arm64/kernel/stacktrace.c
@@ -69,6 +69,9 @@ int notrace unwind_frame(struct task_struct *tsk, struct stackframe *frame)
frame->fp = READ_ONCE_NOCHECK(*(unsigned long *)(fp));
frame->pc = READ_ONCE_NOCHECK(*(unsigned long *)(fp + 8));
+ if (frame->fp <= fp)
+ return -EINVAL;
+
#ifdef CONFIG_FUNCTION_GRAPH_TRACER
if (tsk->ret_stack &&
(frame->pc == (unsigned long)return_to_handler)) {
--
2.17.1
next prev parent reply other threads:[~2018-09-17 3:17 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 3:03 [PATCH AUTOSEL 4.9 01/57] crypto: skcipher - Fix -Wstringop-truncation warnings Sasha Levin
2018-09-17 3:03 ` [PATCH AUTOSEL 4.9 03/57] vmci: type promotion bug in qp_host_get_user_memory() Sasha Levin
2018-09-17 3:03 ` [PATCH AUTOSEL 4.9 02/57] tsl2550: fix lux1_input error in low light Sasha Levin
2018-09-17 3:03 ` [PATCH AUTOSEL 4.9 04/57] x86/numa_emulation: Fix emulated-to-physical node mapping Sasha Levin
2018-09-17 3:03 ` [PATCH AUTOSEL 4.9 05/57] staging: rts5208: fix missing error check on call to rtsx_write_register Sasha Levin
2018-09-17 3:03 ` [PATCH AUTOSEL 4.9 06/57] uwb: hwa-rc: fix memory leak at probe Sasha Levin
2018-09-17 3:03 ` [PATCH AUTOSEL 4.9 07/57] power: vexpress: fix corruption in notifier registration Sasha Levin
2018-09-17 3:03 ` [PATCH AUTOSEL 4.9 08/57] iommu/amd: make sure TLB to be flushed before IOVA freed Sasha Levin
2018-09-17 3:03 ` [PATCH AUTOSEL 4.9 10/57] USB: serial: kobil_sct: fix modem-status error handling Sasha Levin
2018-09-17 3:03 ` [PATCH AUTOSEL 4.9 09/57] Bluetooth: Add a new Realtek 8723DE ID 0bda:b009 Sasha Levin
2018-09-17 3:03 ` [PATCH AUTOSEL 4.9 12/57] s390/mm: correct allocate_pgste proc_handler callback Sasha Levin
2018-09-17 3:03 ` [PATCH AUTOSEL 4.9 11/57] 6lowpan: iphc: reset mac_header after decompress to fix panic Sasha Levin
2018-09-17 3:03 ` [PATCH AUTOSEL 4.9 13/57] power: remove possible deadlock when unregistering power_supply Sasha Levin
2018-09-17 3:03 ` Sasha Levin [this message]
2018-09-17 3:03 ` [PATCH AUTOSEL 4.9 14/57] md-cluster: clear another node's suspend_area after the copy is finished Sasha Levin
2018-09-17 3:03 ` [PATCH AUTOSEL 4.9 17/57] media: exynos4-is: Prevent NULL pointer dereference in __isp_video_try_fmt() Sasha Levin
2018-09-17 3:03 ` [PATCH AUTOSEL 4.9 16/57] IB/core: type promotion bug in rdma_rw_init_one_mr() Sasha Levin
2018-09-17 3:03 ` [PATCH AUTOSEL 4.9 18/57] powerpc/kdump: Handle crashkernel memory reservation failure Sasha Levin
2018-09-17 3:03 ` [PATCH AUTOSEL 4.9 19/57] media: fsl-viu: fix error handling in viu_of_probe() Sasha Levin
2018-09-17 3:03 ` [PATCH AUTOSEL 4.9 20/57] media: sta2x11: Add video_device and vb2_queue locks Sasha Levin
2018-09-17 11:50 ` Ezequiel Garcia
2018-09-27 19:52 ` Sasha Levin
2018-09-17 3:03 ` [PATCH AUTOSEL 4.9 22/57] ARM: hwmod: RTC: Don't assume lock/unlock will be called with irq enabled Sasha Levin
2018-09-17 3:03 ` [PATCH AUTOSEL 4.9 21/57] x86/tsc: Add missing header to tsc_msr.c Sasha Levin
2018-09-17 3:03 ` [PATCH AUTOSEL 4.9 23/57] x86/entry/64: Add two more instruction suffixes Sasha Levin
2018-09-17 3:03 ` [PATCH AUTOSEL 4.9 25/57] scsi: klist: Make it safe to use klists in atomic context Sasha Levin
2018-09-17 3:03 ` [PATCH AUTOSEL 4.9 24/57] scsi: target/iscsi: Make iscsit_ta_authentication() respect the output buffer size Sasha Levin
2018-09-17 3:03 ` [PATCH AUTOSEL 4.9 26/57] scsi: ibmvscsi: Improve strings handling Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 28/57] powerpc/powernv/ioda2: Reduce upper limit for DMA window size Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 27/57] usb: wusbcore: security: cast sizeof to int for comparison Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 30/57] s390/extmem: fix gcc 8 stringop-overflow warning Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 29/57] alarmtimer: Prevent overflow for relative nanosleep Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 31/57] ALSA: snd-aoa: add of_node_put() in error path Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 32/57] media: s3c-camif: ignore -ENOIOCTLCMD from v4l2_subdev_call for s_power Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 33/57] media: soc_camera: ov772x: correct setting of banding filter Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 34/57] media: omap3isp: zero-initialize the isp cam_xclk{a,b} initial data Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 35/57] staging: android: ashmem: Fix mmap size validation Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 36/57] drivers/tty: add error handling for pcmcia_loop_config Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 37/57] media: tm6000: add error handling for dvb_register_adapter Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 38/57] ALSA: hda: Add AZX_DCAPS_PM_RUNTIME for AMD Raven Ridge Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 40/57] ath10k: protect ath10k_htt_rx_ring_free with rx_ring.lock Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 39/57] net: phy: xgmiitorgmii: Check read_status results Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 41/57] net: phy: xgmiitorgmii: Check phy_driver ready before accessing Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 42/57] drm/sun4i: Fix releasing node when enumerating enpoints Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 43/57] rndis_wlan: potential buffer overflow in rndis_wlan_auth_indication() Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 45/57] ARM: mvebu: declare asm symbols as character arrays in pmsu.c Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 44/57] wlcore: Add missing PM call for wlcore_cmd_wait_for_event_or_timeout() Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 46/57] HID: hid-ntrig: add error handling for sysfs_create_group Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 48/57] scsi: bnx2i: add error handling for ioremap_nocache Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 47/57] perf/x86/intel/lbr: Fix incomplete LBR call stack Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 49/57] audit: Fix extended comparison of GID/EGID Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 50/57] scsi: megaraid_sas: Update controller info during resume Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 51/57] EDAC, i7core: Fix memleaks and use-after-free on probe and remove Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 52/57] ASoC: dapm: Fix potential DAI widget pointer deref when linking DAIs Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 53/57] module: exclude SHN_UNDEF symbols from kallsyms api Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 55/57] nfsd: fix corrupted reply to badly ordered compound Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 54/57] gpio: Fix wrong rounding in gpio-menz127 Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 56/57] EDAC: Fix memleak in module init error path Sasha Levin
2018-09-17 3:04 ` [PATCH AUTOSEL 4.9 57/57] ARM: dts: dra7: fix DCAN node addresses Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180917030340.378-15-alexander.levin@microsoft.com \
--to=alexander.levin@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=stable@vger.kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox