From: Greg KH <gregkh@linuxfoundation.org>
To: KY Srinivasan <kys@microsoft.com>
Cc: "olaf@aepfle.de" <olaf@aepfle.de>,
Stephen Hemminger <sthemmin@microsoft.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Michael Kelley (EOSG)" <Michael.H.Kelley@microsoft.com>,
"apw@canonical.com" <apw@canonical.com>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
vkuznets <vkuznets@redhat.com>
Subject: Re: [PATCH 2/2] tools: hv: fcopy: set 'error' in case an unknown operation was requested
Date: Mon, 17 Sep 2018 16:28:28 +0200 [thread overview]
Message-ID: <20180917142828.GA31799@kroah.com> (raw)
In-Reply-To: <MW2PR2101MB11138F9E55814399F152859FA01E0@MW2PR2101MB1113.namprd21.prod.outlook.com>
On Mon, Sep 17, 2018 at 02:16:48PM +0000, KY Srinivasan wrote:
>
>
> > -----Original Message-----
> > From: Greg KH <gregkh@linuxfoundation.org>
> > Sent: Sunday, September 16, 2018 9:56 PM
> > To: KY Srinivasan <kys@microsoft.com>
> > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org;
> > olaf@aepfle.de; apw@canonical.com; jasowang@redhat.com; Stephen
> > Hemminger <sthemmin@microsoft.com>; Michael Kelley (EOSG)
> > <Michael.H.Kelley@microsoft.com>; vkuznets <vkuznets@redhat.com>
> > Subject: Re: [PATCH 2/2] tools: hv: fcopy: set 'error' in case an unknown
> > operation was requested
> >
> > On Mon, Sep 17, 2018 at 04:14:55AM +0000, kys@linuxonhyperv.com wrote:
> > > From: Vitaly Kuznetsov <vkuznets@redhat.com>
> > >
> > > 'error' variable is left uninitialized in case we see an unknown operation.
> > > As we don't immediately return and proceed to pwrite() we need to set it
> > > to something, HV_E_FAIL sounds good enough.
> > >
> > > Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > > ---
> > > tools/hv/hv_fcopy_daemon.c | 1 +
> > > 1 file changed, 1 insertion(+)
> >
> > No need to backport for stable?
> Thanks for pointing this out. Should I resubmit with the stable tag?
I can do it... :)
next prev parent reply other threads:[~2018-09-17 14:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 4:13 [PATCH 0/2] Drivers: hv: Miscellaneous fixes kys
2018-09-17 4:14 ` [PATCH 1/2] Drivers: hv: vmbus: Use get/put_cpu() in vmbus_connect() kys
2018-09-17 4:14 ` [PATCH 2/2] tools: hv: fcopy: set 'error' in case an unknown operation was requested kys
2018-09-17 4:56 ` Greg KH
2018-09-17 14:16 ` KY Srinivasan
2018-09-17 14:28 ` Greg KH [this message]
2018-09-17 15:25 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180917142828.GA31799@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Michael.H.Kelley@microsoft.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox