From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B309ECE560 for ; Mon, 17 Sep 2018 14:28:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 087202098A for ; Mon, 17 Sep 2018 14:28:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 087202098A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728770AbeIQT4H (ORCPT ); Mon, 17 Sep 2018 15:56:07 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:44418 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727021AbeIQT4H (ORCPT ); Mon, 17 Sep 2018 15:56:07 -0400 Received: from localhost (ip-213-127-77-73.ip.prioritytelecom.net [213.127.77.73]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 92B2EEA3; Mon, 17 Sep 2018 14:28:31 +0000 (UTC) Date: Mon, 17 Sep 2018 16:28:28 +0200 From: Greg KH To: KY Srinivasan Cc: "olaf@aepfle.de" , Stephen Hemminger , "jasowang@redhat.com" , "linux-kernel@vger.kernel.org" , "Michael Kelley (EOSG)" , "apw@canonical.com" , "devel@linuxdriverproject.org" , vkuznets Subject: Re: [PATCH 2/2] tools: hv: fcopy: set 'error' in case an unknown operation was requested Message-ID: <20180917142828.GA31799@kroah.com> References: <20180917041352.11402-1-kys@linuxonhyperv.com> <20180917041455.11455-1-kys@linuxonhyperv.com> <20180917041455.11455-2-kys@linuxonhyperv.com> <20180917045613.GA25435@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 17, 2018 at 02:16:48PM +0000, KY Srinivasan wrote: > > > > -----Original Message----- > > From: Greg KH > > Sent: Sunday, September 16, 2018 9:56 PM > > To: KY Srinivasan > > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; > > olaf@aepfle.de; apw@canonical.com; jasowang@redhat.com; Stephen > > Hemminger ; Michael Kelley (EOSG) > > ; vkuznets > > Subject: Re: [PATCH 2/2] tools: hv: fcopy: set 'error' in case an unknown > > operation was requested > > > > On Mon, Sep 17, 2018 at 04:14:55AM +0000, kys@linuxonhyperv.com wrote: > > > From: Vitaly Kuznetsov > > > > > > 'error' variable is left uninitialized in case we see an unknown operation. > > > As we don't immediately return and proceed to pwrite() we need to set it > > > to something, HV_E_FAIL sounds good enough. > > > > > > Signed-off-by: Vitaly Kuznetsov > > > Signed-off-by: K. Y. Srinivasan > > > --- > > > tools/hv/hv_fcopy_daemon.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > No need to backport for stable? > Thanks for pointing this out. Should I resubmit with the stable tag? I can do it... :)