From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CE3EECE560 for ; Mon, 17 Sep 2018 21:16:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 288B62086E for ; Mon, 17 Sep 2018 21:16:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 288B62086E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728583AbeIRCpd (ORCPT ); Mon, 17 Sep 2018 22:45:33 -0400 Received: from mga03.intel.com ([134.134.136.65]:59587 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728559AbeIRCpc (ORCPT ); Mon, 17 Sep 2018 22:45:32 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Sep 2018 14:16:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,386,1531810800"; d="scan'208";a="92549726" Received: from maclarck-mobl1.ger.corp.intel.com (HELO localhost) ([10.249.39.44]) by orsmga002.jf.intel.com with ESMTP; 17 Sep 2018 14:16:23 -0700 Date: Tue, 18 Sep 2018 00:16:22 +0300 From: Jarkko Sakkinen To: Roberto Sassu Cc: linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] tpm: retrieve digest size of unknown algorithms with PCR read Message-ID: <20180917211622.GC6716@linux.intel.com> References: <20180905114202.7757-1-roberto.sassu@huawei.com> <20180905114202.7757-4-roberto.sassu@huawei.com> <20180916123749.GF5040@linux.intel.com> <322eb81b-3f3e-e37e-5fb0-a37aad3d06d7@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <322eb81b-3f3e-e37e-5fb0-a37aad3d06d7@huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 17, 2018 at 12:02:56PM +0200, Roberto Sassu wrote: > This code has the same behavior of tpm2_get_pcr_allocation(). If some > banks are not used, set the algorithm of the first unused to > TPM_ALG_ERROR. My point is that maybe it would sense to use zero for that in order to make code a bit simpler. /Jarkko