From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBEA7ECE567 for ; Tue, 18 Sep 2018 10:16:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 739DD20C0E for ; Tue, 18 Sep 2018 10:16:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 739DD20C0E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729353AbeIRPsp (ORCPT ); Tue, 18 Sep 2018 11:48:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51246 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727161AbeIRPso (ORCPT ); Tue, 18 Sep 2018 11:48:44 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 856488553D; Tue, 18 Sep 2018 10:16:50 +0000 (UTC) Received: from ming.t460p (ovpn-8-16.pek2.redhat.com [10.72.8.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F17BC2C8C3; Tue, 18 Sep 2018 10:16:42 +0000 (UTC) Date: Tue, 18 Sep 2018 18:16:37 +0800 From: Ming Lei To: linux-kernel@vger.kernel.org Cc: Tejun Heo , Jianchao Wang , Kent Overstreet , linux-block@vger.kernel.org, Christoph Hellwig , linux-nvme@lists.infradead.org, Keith Busch Subject: Re: [PATCH 0/3] blk-mq: allow to unfreeze queue when io isn't drained Message-ID: <20180918101636.GA13212@ming.t460p> References: <20180918101310.13154-1-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180918101310.13154-1-ming.lei@redhat.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 18 Sep 2018 10:16:50 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 18, 2018 at 06:13:07PM +0800, Ming Lei wrote: > Hi, > > The 1st patch introduces percpu_ref_resurge() for implementing > blk_mq_unfreeze_queue_no_drain_io(). > > The 2nd patch introdces blk_mq_unfreeze_queue_no_drain_io() for > cases in which queue can be unfreeze without draininig IO. > > The 3rd patch applies blk_mq_unfreeze_queue_no_drain_io() to > NVMe PCI timeout, so that IO hang may be avoided inside > nvme_reset_work() when new IO timeout is triggered. > > Part of idea is from Jianchao's early work: > > https://marc.info/?l=linux-kernel&m=153612052611020&w=2 > > Ming Lei (3): > lib/percpu-refcount: introduce percpu_ref_resurge() > blk-mq: introduce blk_mq_unfreeze_queue_no_drain_io > nvme: don't drain IO in nvme_reset_work() > > block/blk-mq.c | 25 ++++++++++++++-- > drivers/nvme/host/core.c | 12 +++++--- > drivers/nvme/host/nvme.h | 2 +- > drivers/nvme/host/pci.c | 3 +- > include/linux/blk-mq.h | 1 + > include/linux/percpu-refcount.h | 1 + > lib/percpu-refcount.c | 63 ++++++++++++++++++++++++++++++++++------- > 7 files changed, 87 insertions(+), 20 deletions(-) > > Cc: Tejun Heo > Cc: Jianchao Wang > Cc: Kent Overstreet > Cc: linux-block@vger.kernel.org > Cc: Christoph Hellwig > Cc: linux-nvme@lists.infradead.org > Cc: Keith Busch > Ooops, there is one extra patch missed. Please ignore this series. Thanks, Ming