From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Anton Vasilyev <vasilyev@ispras.ru>
Cc: Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
Jiri Slaby <jslaby@suse.com>,
linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org
Subject: Re: [PATCH v2] tty: rocket: Fix possible buffer overwrite on register_PCI
Date: Tue, 18 Sep 2018 15:37:59 +0200 [thread overview]
Message-ID: <20180918133759.GA20312@kroah.com> (raw)
In-Reply-To: <20180806141057.7105-1-vasilyev@ispras.ru>
On Mon, Aug 06, 2018 at 05:10:57PM +0300, Anton Vasilyev wrote:
> If number of isa and pci boards exceed NUM_BOARDS on the path
> rp_init()->init_PCI()->register_PCI() then buffer overwrite occurs
> in register_PCI() on assign rcktpt_io_addr[i].
>
> The patch adds check on upper bound for index of registered
> board in register_PCI.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
> ---
> v2: do not enable device which will not be managed by driver.
> Based on Alan's comment.
This patch doesn't apply to my tree at all :(
Can you rebase and resend?
thanks,
greg k-h
prev parent reply other threads:[~2018-09-18 13:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 13:39 [PATCH] tty: rocket: Fix possible buffer overwrite on register_PCI Anton Vasilyev
2018-08-02 14:02 ` Alan Cox
2018-08-06 14:10 ` [PATCH v2] " Anton Vasilyev
2018-09-18 13:37 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180918133759.GA20312@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=jslaby@suse.com \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vasilyev@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox