From: Steven Rostedt <rostedt@goodmis.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: He Zhe <zhe.he@windriver.com>,
pmladek@suse.com, sergey.senozhatsky@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] printk: Fix panic caused by passing log_buf_len to command line
Date: Tue, 18 Sep 2018 23:05:37 -0400 [thread overview]
Message-ID: <20180918230537.30448bd7@vmware.local.home> (raw)
In-Reply-To: <20180919024754.GA15128@jagdpanzerIV>
On Wed, 19 Sep 2018 11:47:54 +0900
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> wrote:
> On (09/18/18 22:43), Steven Rostedt wrote:
> > > First - switch to u64 size.
> > > Second - check for NULL str.
> > >
> > I think I would switch it around. Check for NULL first, and then switch
> > to u64. It was always an int, do we need to backport converting it to
> > u64 to stable? The NULL check is a definite, the overflow of int
> > shouldn't crash anything.
>
> Agreed. This order makes much more sense. Do you mind, tho, to have
> "unsigned int size" in the first patch along with NULL str check?
> Just to silent the checkpatch.
>
I guess that doesn't hurt. I'd personally would keep it separate (just
fix what's broken), but it's such a slight change, I don't have any
strong feelings about it.
Thanks,
-- Steve
next prev parent reply other threads:[~2018-09-19 3:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 17:17 [PATCH v2 1/2] printk: Fix panic caused by passing log_buf_len to command line zhe.he
2018-09-18 17:17 ` [PATCH v2 2/2] printk: Add KBUILD_MODNAME and correct bare use of unsigned zhe.he
2018-09-19 2:06 ` Sergey Senozhatsky
2018-09-19 11:20 ` Petr Mladek
2018-09-19 1:50 ` [PATCH v2 1/2] printk: Fix panic caused by passing log_buf_len to command line Sergey Senozhatsky
2018-09-19 2:27 ` He Zhe
2018-09-19 2:39 ` Sergey Senozhatsky
2018-09-19 2:43 ` Steven Rostedt
2018-09-19 2:47 ` Sergey Senozhatsky
2018-09-19 3:05 ` Steven Rostedt [this message]
2018-09-20 16:16 ` He Zhe
2018-09-20 16:30 ` Steven Rostedt
2018-09-21 7:37 ` Petr Mladek
2018-09-22 15:36 ` He Zhe
2018-09-25 12:16 ` Sergey Senozhatsky
2018-09-25 12:01 ` Sergey Senozhatsky
2018-09-25 12:23 ` Petr Mladek
2018-09-25 12:37 ` Sergey Senozhatsky
2018-09-25 13:31 ` Sergey Senozhatsky
2018-09-25 15:31 ` He Zhe
2018-09-26 11:05 ` Petr Mladek
2018-09-28 7:35 ` Sergey Senozhatsky
2018-09-28 8:22 ` He Zhe
2018-09-19 6:44 ` Sergey Senozhatsky
2018-09-19 10:09 ` He Zhe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180918230537.30448bd7@vmware.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=zhe.he@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox