Re: [PATCH AUTOSEL 4.9 30/34] dmaengine: hsu: Support dmaengine_terminate_sync()

Sasha Levin
2018-09-24T00:55:23Z

On Wed, Sep 19, 2018 at 05:38:51PM -0700, Vinod wrote:
>On 15-09-18, 01:34, Sasha Levin wrote:
>> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>
>> [ Upstream commit 2abc66cd499aa16876e45c6438788902f7d1ce22 ]
>>
>> It appears that the driver misses the support of dmaengine_terminate_sync().
>> Since many of callers expects this behaviour implement the new
>> device_synchronize() callback to allow proper synchronization when stopping
>> a channel.
>
>This adds missing support for an optional call, but I am not aware of
>any reports of breakage due to missing this patch. Do you want to carry
>this for stable?

I guess that using the word "expect" in the commit log suggested to me
that this wasn't optional.

I'll drop it, thanks!