From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Laura Abbott <labbott@redhat.com>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] kgdboc: Fix warning with module build
Date: Thu, 20 Sep 2018 09:16:52 +0200 [thread overview]
Message-ID: <20180920071652.GA12843@kroah.com> (raw)
In-Reply-To: <20180920015901.4639-1-labbott@redhat.com>
On Wed, Sep 19, 2018 at 06:59:01PM -0700, Laura Abbott wrote:
>
> After 2dd453168643 ("kgdboc: Fix restrict error"), kgdboc_option_setup is
> now only used when built in, resulting in a warning when compiled as a
> module:
>
> drivers/tty/serial/kgdboc.c:134:12: warning: 'kgdboc_option_setup' defined but not used [-Wunused-function]
> static int kgdboc_option_setup(char *opt)
> ^~~~~~~~~~~~~~~~~~~
>
> Move the function under the appropriate ifdef for builtin only.
>
> Fixes: 2dd453168643 ("kgdboc: Fix restrict error")
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> drivers/tty/serial/kgdboc.c | 37 +++++++++++++++++++------------------
> 1 file changed, 19 insertions(+), 18 deletions(-)
You forgot a reported-by: tag :(
I'll go fix it up, thanks for the patch resolving this.
greg k-h
prev parent reply other threads:[~2018-09-20 7:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 3:12 linux-next: build warning after merge of the tty tree Stephen Rothwell
2018-09-20 1:59 ` [PATCH] kgdboc: Fix warning with module build Laura Abbott
2018-09-20 7:16 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920071652.GA12843@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=daniel.thompson@linaro.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox