From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39E4CECE561 for ; Thu, 20 Sep 2018 07:19:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F37412087A for ; Thu, 20 Sep 2018 07:19:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F37412087A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731766AbeITNBf (ORCPT ); Thu, 20 Sep 2018 09:01:35 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:47656 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726014AbeITNBf (ORCPT ); Thu, 20 Sep 2018 09:01:35 -0400 Received: from localhost (ip-213-127-77-73.ip.prioritytelecom.net [213.127.77.73]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 89E9BD6C; Thu, 20 Sep 2018 07:19:32 +0000 (UTC) Date: Thu, 20 Sep 2018 09:19:30 +0200 From: Greg Kroah-Hartman To: Stefan Agner Cc: Miguel Ojeda , Nick Desaulniers , Arnd Bergmann , linux-kernel , Rasmus Villemoes , Eli Friedman , Christopher Li , Kees Cook , Ingo Molnar , Geert Uytterhoeven , Masahiro Yamada , Joe Perches , Dominique Martinet , Linus Torvalds , linux-sparse@vger.kernel.org Subject: Re: [PATCH v2 2/2] Compiler Attributes: naked can be shared Message-ID: <20180920071930.GA11963@kroah.com> References: <20180918165542.4691-1-miguel.ojeda.sandonis@gmail.com> <20180918165542.4691-3-miguel.ojeda.sandonis@gmail.com> <20180918173428.GA21591@kroah.com> <20180919211458.GA8757@kroah.com> <6837090afde15cd5ee155dbfabb0d556@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6837090afde15cd5ee155dbfabb0d556@agner.ch> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 19, 2018 at 11:00:37PM -0700, Stefan Agner wrote: > On 19.09.2018 16:00, Miguel Ojeda wrote: > > On Wed, Sep 19, 2018 at 11:14 PM, Greg Kroah-Hartman > > wrote: > >> On Tue, Sep 18, 2018 at 08:56:04PM +0200, Miguel Ojeda wrote: > >>> Hi Greg, > >>> > >> > >>> Since Linus/Andrew/you > >>> didn't comment on whether you wanted or not this for 4.19, we are > >>> assuming they would go in for 4.20. However, Stefan/Nick/... wanted > >>> this for 4.19 instead, they asked me to extract these patches two > >>> separately for 4.19. I let them comment further on the status of Clang > >>> on arm32. > >> > >> If these do not fix a regression, I don't see how they would be ready > >> for 4.19-final. > > Clang on arm32 worked with v4.18 when using multi_v7_defconfig -CONFIG_EFI. That's a narrow definition :) > With 815f0ddb346c ("include/linux/compiler*.h: make compiler-*.h mutually > exclusive") it broke on v4.19-rc1. IMHO this is a regression and we should > consider this two patches as a fix for it. Why not just revert 815f0ddb346c instead and work to get it right for 4.20-rc1? thanks, greg k-h