From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26218ECE561 for ; Thu, 20 Sep 2018 07:24:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DCD0821523 for ; Thu, 20 Sep 2018 07:24:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCD0821523 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731828AbeITNGf (ORCPT ); Thu, 20 Sep 2018 09:06:35 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:47978 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729647AbeITNGe (ORCPT ); Thu, 20 Sep 2018 09:06:34 -0400 Received: from localhost (ip-213-127-77-73.ip.prioritytelecom.net [213.127.77.73]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 64BBFD8B; Thu, 20 Sep 2018 07:24:31 +0000 (UTC) Date: Thu, 20 Sep 2018 09:24:28 +0200 From: Greg KH To: Geert Uytterhoeven Cc: Trent Piepho , Linux Kernel Mailing List , Russell King , Todd Kjos , Geert Uytterhoeven Subject: Re: [PATCH] ARM: amba: Fix leak of driver_override attribute value Message-ID: <20180920072428.GA12411@kroah.com> References: <20180919234721.16042-1-tpiepho@impinj.com> <20180920070937.GA9609@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 20, 2018 at 09:16:36AM +0200, Geert Uytterhoeven wrote: > Hi Greg, > > On Thu, Sep 20, 2018 at 9:09 AM Greg KH wrote: > > On Thu, Sep 20, 2018 at 08:48:36AM +0200, Geert Uytterhoeven wrote: > > > On Thu, Sep 20, 2018 at 1:48 AM Trent Piepho wrote: > > > > If driver_override was set when a device was released the string would > > > > not be kfree'ed in amba_device_release and thus leaked when the amba > > > > device was freed. > > > > > > > > Cc: Russell King > > > > Cc: Todd Kjos > > > > Cc: Geert Uytterhoeven > > > > Cc: Greg Kroah-Hartman > > > > Signed-off-by: Trent Piepho > > > > > > Reported-by: Geert Uytterhoeven > > > Fixes: 3cf385713460eb2b ("ARM: 8256/1: driver coamba: add device > > > binding path 'driver_override'") > > > > Then it should also have a cc: stable, right? > > Perhaps. I usually leave that up to the maintainer, else git send-email sends > it to stable immediately. That's fine, no one ever complains about that. In fact it is _good_ to have that happen, as it gives us stable people a "heads up" that something is coming to resolve a reported problems. > The modern backporting AI will consider it anyway, due to the subject, and > the Fixes tag, right? Don't count on the "AI" to pick things up if you _know_ it resolves a problem, like you have said here. So please, just add it when you know it needs to be backported, otherwise it might never get backported. thanks, greg k-h