From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Michal Simek <michal.simek@xilinx.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu,
Jiri Slaby <jslaby@suse.com>,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/2] serial: uartps: Change uart ID port allocation
Date: Thu, 20 Sep 2018 13:32:25 +0200 [thread overview]
Message-ID: <20180920113225.GA19956@kroah.com> (raw)
In-Reply-To: <dcf1c72203baf2629492dce765ce2d555316be0c.1537282676.git.michal.simek@xilinx.com>
On Tue, Sep 18, 2018 at 04:57:59PM +0200, Michal Simek wrote:
> For IPs which have alias algorightm all the time using that alias and
> minor number. It means serial20 alias ends up as ttyPS20.
>
> If alias is not setup for probed IP instance the first unused position is
> used but that needs to be checked if it is really empty because another
> instance doesn't need to be probed at that time. of_alias_get_alias_list()
> fills alias bitmap which exactly shows which ID is free.
> If alias pointing to different not compatible IP, it is free to use.
>
> cdns_get_id() call is placed below structure allocation to simplify
> error path.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> Changes in v3: None
> Changes in v2:
> - Add handle of return value from of_alias_get_alias_list
>
> Needs to be applied on the top of
> https://lkml.org/lkml/2018/9/3/404
> https://lkml.org/lkml/2018/9/3/400 (minor that's why just in case)
>
> Greg: Please apply it with
> "of: base: Introduce of_alias_get_alias_list() to check alias IDs
> Rob is ok with that.
I don't have that patch, can you resend the whole series?
thanks,
greg k-h
next prev parent reply other threads:[~2018-09-20 11:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 14:57 [PATCH v3 1/2] of: base: Introduce of_alias_get_alias_list() to check alias IDs Michal Simek
2018-09-18 14:57 ` [PATCH v3 2/2] serial: uartps: Change uart ID port allocation Michal Simek
2018-09-20 11:32 ` Greg Kroah-Hartman [this message]
2018-09-20 11:43 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920113225.GA19956@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox