From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2537ECE561 for ; Thu, 20 Sep 2018 12:07:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 85ACF2152F for ; Thu, 20 Sep 2018 12:07:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="DMcRQjtY"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="SYjoyUCB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85ACF2152F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387599AbeITRuU (ORCPT ); Thu, 20 Sep 2018 13:50:20 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34894 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726669AbeITRuU (ORCPT ); Thu, 20 Sep 2018 13:50:20 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id A603560BE3; Thu, 20 Sep 2018 12:07:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1537445229; bh=+Ezk40uLLR7rQvXJ/9k0hJBNe8cRfqyf5cFRjTolsx4=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=DMcRQjtYx5ngIx/EONqsTc0aZnnoCh4V/oJgLfTwTJtBNJ110JQyYuzFZn3tLLohB twpDpiFfNWkK1ng5pnQHXtEuDhIF1VqZ+uv36A27ObB8HWkSyHptamkeX+y7LGVh0f rtWeZxLNWhKRxHlNCeewtaLdiR+8M4lTZDIzQ0J8= Received: from potku.adurom.net (88-114-240-52.elisa-laajakaista.fi [88.114.240.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 124B0601A8; Thu, 20 Sep 2018 12:07:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1537445228; bh=+Ezk40uLLR7rQvXJ/9k0hJBNe8cRfqyf5cFRjTolsx4=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=SYjoyUCB6iaoabIwSSsr4PqQShx2UMS2BKaXG5EJoqDq+y15xJcssDbs3DBpUmAU1 rVD00sc5zaOklOMS2dAdDBmjoXqaeSVdccD4XmXsTgzJRlmYzwAF4mWXHKwtzXEOfK QLBaEOWxsrRYajTnS77odpjoJ0lt4icokWhOVbAM= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 124B0601A8 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] brcm80211: remove redundant condition check before debugfs_remove_recursive From: Kalle Valo In-Reply-To: <1536761412-24932-1-git-send-email-zhongjiang@huawei.com> References: <1536761412-24932-1-git-send-email-zhongjiang@huawei.com> To: zhong jiang Cc: , , , , , , , User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20180920120709.A603560BE3@smtp.codeaurora.org> Date: Thu, 20 Sep 2018 12:07:09 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org zhong jiang wrote: > debugfs_remove_recursive has taken IS_ERR_OR_NULL into account. So just > remove the condition check before debugfs_remove_recursive. > > Signed-off-by: zhong jiang It seems you already submitted an identical patch four days earlier: https://patchwork.kernel.org/patch/10593061/ Why the duplicate? Please ALWAYS add a changelog and increase the version number: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing -- https://patchwork.kernel.org/patch/10597627/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches