From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 787A3ECE566 for ; Thu, 20 Sep 2018 18:19:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3147D21531 for ; Thu, 20 Sep 2018 18:19:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="js5hjkP5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3147D21531 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388103AbeIUADp (ORCPT ); Thu, 20 Sep 2018 20:03:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:50588 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727171AbeIUADo (ORCPT ); Thu, 20 Sep 2018 20:03:44 -0400 Received: from jouet.infradead.org (unknown [190.15.121.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BE9702152A; Thu, 20 Sep 2018 18:18:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1537467539; bh=9ZYOmBhU4JGj48pyKMkRS3jv3lEIqD03IpMI2mcLiJo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=js5hjkP5ZOHRH0UasoA7ciCXlCkeGrcTWkOD/449rNtJ0ZUL8gzvwozDmcY9C76ix Vx8zq2Lsz4FKPkayQmdc302lSsnGt1CdwbKOx6wCLEcMmVYv/SFkXTJr1cNM65NmnS P2PlbtYJ3AMkNB1Z8t+V2EtfReOL04XyChflKdME= Received: by jouet.infradead.org (Postfix, from userid 1000) id 9416A1401A1; Thu, 20 Sep 2018 15:18:54 -0300 (-03) Date: Thu, 20 Sep 2018 15:18:54 -0300 From: Arnaldo Carvalho de Melo To: Adrian Hunter Cc: Jiri Olsa , Andi Kleen , linux-kernel@vger.kernel.org Subject: Re: RFC/error: Re: [PATCH 3/6] perf tools: Improve thread_stack__event() for trace begin / end Message-ID: <20180920181854.GB9919@kernel.org> References: <20180919112338.20347-1-adrian.hunter@intel.com> <20180919112338.20347-4-adrian.hunter@intel.com> <20180920181352.GA9919@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180920181352.GA9919@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Sep 20, 2018 at 03:13:52PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Sep 19, 2018 at 02:23:35PM +0300, Adrian Hunter escreveu: > > + return thread_stack__push(thread->ts, ret_addr, > > + flags && PERF_IP_FLAG_TRACE_END); > > + } else if (flags & PERF_IP_FLAG_TRACE_BEGIN) { > > Some of the build containers caught this: > > util/thread-stack.c:274:14: error: use of logical '&&' with constant operand [-Werror,-Wconstant-logical-operand] > flags && PERF_IP_FLAG_TRACE_END); > ^ ~~~~~~~~~~~~~~~~~~~~~~ > util/thread-stack.c:274:14: note: use '&' for a bitwise operation > flags && PERF_IP_FLAG_TRACE_END); > ^~ > & > util/thread-stack.c:274:14: note: remove constant to silence this warning > flags && PERF_IP_FLAG_TRACE_END); > ~^~~~~~~~~~~~~~~~~~~~~~~~~ > 1 error generated. > > > -------------------------- > > Should be a '&' as suggested by: > > 16 146.45 debian:9 : FAIL gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516 > 17 138.35 debian:experimental : FAIL gcc (Debian 8.2.0-4) 8.2.0 Ok, the compilers that caught this was: debian:9: clang version 3.8.1-24 (tags/RELEASE_381/final) debian:experimental: clang version 6.0.1-6 (tags/RELEASE_601/final) Those gcc versions (6.3 and 8.2) compiled it without warnings. - Arnaldo > > I'm changing this here, please Ack. > > - Arnaldo