* [PATCH] kernel: kexec_file: remove some duplicated include file
@ 2018-09-20 5:12 zhong jiang
2018-09-21 2:15 ` Baoquan He
0 siblings, 1 reply; 5+ messages in thread
From: zhong jiang @ 2018-09-20 5:12 UTC (permalink / raw)
To: ebiederm; +Cc: kexec, linux-kernel
kexec.h and slab.h have duplicated include. hence just remove
redundant file.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
kernel/kexec_file.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
index c6a3b68..35cf0ad 100644
--- a/kernel/kexec_file.c
+++ b/kernel/kexec_file.c
@@ -25,8 +25,6 @@
#include <linux/elf.h>
#include <linux/elfcore.h>
#include <linux/kernel.h>
-#include <linux/kexec.h>
-#include <linux/slab.h>
#include <linux/syscalls.h>
#include <linux/vmalloc.h>
#include "kexec_internal.h"
--
1.7.12.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] kernel: kexec_file: remove some duplicated include file
2018-09-20 5:12 [PATCH] kernel: kexec_file: remove some duplicated include file zhong jiang
@ 2018-09-21 2:15 ` Baoquan He
2018-09-21 2:27 ` zhong jiang
0 siblings, 1 reply; 5+ messages in thread
From: Baoquan He @ 2018-09-21 2:15 UTC (permalink / raw)
To: zhong jiang; +Cc: ebiederm, kexec, linux-kernel
On 09/20/18 at 01:12pm, zhong jiang wrote:
> kexec.h and slab.h have duplicated include. hence just remove
> redundant file.
They have duplicated include, why do you remove both of them?
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> kernel/kexec_file.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
> index c6a3b68..35cf0ad 100644
> --- a/kernel/kexec_file.c
> +++ b/kernel/kexec_file.c
> @@ -25,8 +25,6 @@
> #include <linux/elf.h>
> #include <linux/elfcore.h>
> #include <linux/kernel.h>
> -#include <linux/kexec.h>
> -#include <linux/slab.h>
> #include <linux/syscalls.h>
> #include <linux/vmalloc.h>
> #include "kexec_internal.h"
> --
> 1.7.12.4
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] kernel: kexec_file: remove some duplicated include file
2018-09-21 2:15 ` Baoquan He
@ 2018-09-21 2:27 ` zhong jiang
2018-09-21 2:35 ` Baoquan He
0 siblings, 1 reply; 5+ messages in thread
From: zhong jiang @ 2018-09-21 2:27 UTC (permalink / raw)
To: Baoquan He; +Cc: ebiederm, kexec, linux-kernel
On 2018/9/21 10:15, Baoquan He wrote:
> On 09/20/18 at 01:12pm, zhong jiang wrote:
>> kexec.h and slab.h have duplicated include. hence just remove
>> redundant file.
> They have duplicated include, why do you remove both of them?
because we include the kexec.h and slab.h twice in kexec_file.c. It's unnecessary.
Thanks,
zhong jiang
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>> ---
>> kernel/kexec_file.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
>> index c6a3b68..35cf0ad 100644
>> --- a/kernel/kexec_file.c
>> +++ b/kernel/kexec_file.c
>> @@ -25,8 +25,6 @@
>> #include <linux/elf.h>
>> #include <linux/elfcore.h>
>> #include <linux/kernel.h>
>> -#include <linux/kexec.h>
>> -#include <linux/slab.h>
>> #include <linux/syscalls.h>
>> #include <linux/vmalloc.h>
>> #include "kexec_internal.h"
>> --
>> 1.7.12.4
>>
>>
>> _______________________________________________
>> kexec mailing list
>> kexec@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/kexec
> .
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] kernel: kexec_file: remove some duplicated include file
2018-09-21 2:27 ` zhong jiang
@ 2018-09-21 2:35 ` Baoquan He
2018-09-21 2:48 ` zhong jiang
0 siblings, 1 reply; 5+ messages in thread
From: Baoquan He @ 2018-09-21 2:35 UTC (permalink / raw)
To: zhong jiang; +Cc: ebiederm, kexec, linux-kernel
On 09/21/18 at 10:27am, zhong jiang wrote:
> On 2018/9/21 10:15, Baoquan He wrote:
> > On 09/20/18 at 01:12pm, zhong jiang wrote:
> >> kexec.h and slab.h have duplicated include. hence just remove
> >> redundant file.
> > They have duplicated include, why do you remove both of them?
> because we include the kexec.h and slab.h twice in kexec_file.c. It's unnecessary.
OK, Could you rewrite the log with this? The old log makes me think
kexec.h and slab.h themselves have duplicated include.
>
> Thanks,
> zhong jiang
> >> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> >> ---
> >> kernel/kexec_file.c | 2 --
> >> 1 file changed, 2 deletions(-)
> >>
> >> diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
> >> index c6a3b68..35cf0ad 100644
> >> --- a/kernel/kexec_file.c
> >> +++ b/kernel/kexec_file.c
> >> @@ -25,8 +25,6 @@
> >> #include <linux/elf.h>
> >> #include <linux/elfcore.h>
> >> #include <linux/kernel.h>
> >> -#include <linux/kexec.h>
> >> -#include <linux/slab.h>
> >> #include <linux/syscalls.h>
> >> #include <linux/vmalloc.h>
> >> #include "kexec_internal.h"
> >> --
> >> 1.7.12.4
> >>
> >>
> >> _______________________________________________
> >> kexec mailing list
> >> kexec@lists.infradead.org
> >> http://lists.infradead.org/mailman/listinfo/kexec
> > .
> >
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] kernel: kexec_file: remove some duplicated include file
2018-09-21 2:35 ` Baoquan He
@ 2018-09-21 2:48 ` zhong jiang
0 siblings, 0 replies; 5+ messages in thread
From: zhong jiang @ 2018-09-21 2:48 UTC (permalink / raw)
To: Baoquan He; +Cc: ebiederm, kexec, linux-kernel
On 2018/9/21 10:35, Baoquan He wrote:
> On 09/21/18 at 10:27am, zhong jiang wrote:
>> On 2018/9/21 10:15, Baoquan He wrote:
>>> On 09/20/18 at 01:12pm, zhong jiang wrote:
>>>> kexec.h and slab.h have duplicated include. hence just remove
>>>> redundant file.
>>> They have duplicated include, why do you remove both of them?
>> because we include the kexec.h and slab.h twice in kexec_file.c. It's unnecessary.
> OK, Could you rewrite the log with this? The old log makes me think
> kexec.h and slab.h themselves have duplicated include.
Ok, I will rewrite the log and repost in v2. Thanks
Sincerely,
zhong jiang
>> Thanks,
>> zhong jiang
>>>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>>>> ---
>>>> kernel/kexec_file.c | 2 --
>>>> 1 file changed, 2 deletions(-)
>>>>
>>>> diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
>>>> index c6a3b68..35cf0ad 100644
>>>> --- a/kernel/kexec_file.c
>>>> +++ b/kernel/kexec_file.c
>>>> @@ -25,8 +25,6 @@
>>>> #include <linux/elf.h>
>>>> #include <linux/elfcore.h>
>>>> #include <linux/kernel.h>
>>>> -#include <linux/kexec.h>
>>>> -#include <linux/slab.h>
>>>> #include <linux/syscalls.h>
>>>> #include <linux/vmalloc.h>
>>>> #include "kexec_internal.h"
>>>> --
>>>> 1.7.12.4
>>>>
>>>>
>>>> _______________________________________________
>>>> kexec mailing list
>>>> kexec@lists.infradead.org
>>>> http://lists.infradead.org/mailman/listinfo/kexec
>>> .
>>>
>>
> .
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-09-21 2:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-20 5:12 [PATCH] kernel: kexec_file: remove some duplicated include file zhong jiang
2018-09-21 2:15 ` Baoquan He
2018-09-21 2:27 ` zhong jiang
2018-09-21 2:35 ` Baoquan He
2018-09-21 2:48 ` zhong jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox